Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor advisor script #237

Open
jtemporal opened this issue May 18, 2017 · 5 comments
Open

Refactor advisor script #237

jtemporal opened this issue May 18, 2017 · 5 comments

Comments

@jtemporal
Copy link
Collaborator

As I mentioned in #149 there's a little bit of 💅 to be done on fetch_deputies_advisors script.

@jtemporal
Copy link
Collaborator Author

We need to study what changed that this is not working =/

screen shot 2017-06-13 at 10 03 27 am

@jtemporal
Copy link
Collaborator Author

hey @bruno-schmidt since you were the one majorly responsible for this script existence I thought you might want to take a look into it, what do you think? 😄

@jtemporal jtemporal added the bug label Jun 13, 2017
@andrewsmedina
Copy link

I'm not 100% sure, but I believe that the problem is that this page can't be scraped by a curl scrapper like requests.

A way to scrape this page is to use something like splinter (https://splinter.readthedocs.io/en/latest/) or selenium.

What do you think about to use splinter to do it? If you agree I can make a PR to fix this bug.

@bruno-schmidt
Copy link
Contributor

Hey guys!

@jtemporal I just checked it out and the HTML of the page changed a lot. It was not that nice when I and @cuducos wrote the script lol. Some URL changes also. I'm working on it now. As soon as I have something I will post here n__nd

@bruno-schmidt
Copy link
Contributor

Just pushed a PR (#252) @jtemporal ! I think everything is running fine now :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants