-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi params together with 'axis' #52
Comments
Hi, I've removed the support of extract_activities indeed. It is compatible with multiple value as long as you don't use several impacts : I recommand that you do a "for loop" over your list of impact methods, which I suppose may not be too numerous. Alternatively, there is a on going pull request to provide a "raw" interface to compute_impacts, using Xarray (matrices of arbitrary dimensions) before transforming it to Dataframe. But I didn't have time to look at it / test it yet. |
Thank you for the feedback. I will implement your recommendation on the "for loop" and have a look at the ongoing pull request. |
Apologies, but actually it doesn't seem that
Are you referring to a dev version of lca-algebraic? |
My bad, indeed.
I guess then your best luck is to try the PR of Benoit here :
f68bb3f
De: "Felix Pollet" ***@***.***>
À: "oie-mines-paristech" ***@***.***>
Cc: "Raphael JOLIVET" ***@***.***>, "Comment" ***@***.***>
Envoyé: Lundi 17 Juin 2024 17:29:16
Objet: Re: [oie-mines-paristech/lca_algebraic] Multi params together with 'axis' (Issue #52)
Apologies, but actually it doesn't seem that postMultiLCAAlgebric() with axis can handle multiple values, even with a single impact method:
if lambdas[0].has_axis:
if param_length > 1:
raise Exception("Multi params cannot be used together with 'axis'")
param_length = len(lambdas[0].axis_keys)
Are you referring to a dev version of lca-algebraic?
—
Reply to this email directly, [ #52 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AAJFLQEKZ5NR6VF4N3GTF3LZH36EZAVCNFSM6AAAAABHZ63HLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTG4YTONRYGY | unsubscribe ] .
You are receiving this because you commented. Message ID: <oie-mines-paristech/lca_algebraic/issues/52/2173717686 @ github . com>
|
Hi,
In previous versions of lca_algebraic, the
extract_activities
option ofmultiLCAAlgebric
allowed the contribution of a subset of activities to be calculated. It has been replaced by theaxis
option in v1.1. However,axis
is only compatible for a single set of parameter values. Are there any intentions to enable this feature when a list of parameter values is provided?I used to calculate the contributions of each activity in the following way:
Any idea on how to do this in v1.1? Apart from calling
compute_impacts()
for each parameter value in a loop.Thanks for this wonderful library :-)
The text was updated successfully, but these errors were encountered: