-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return files with consent lists and consent filters #2255
Conversation
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the better way of doing is to have a bool variable on the consultation itself so that we don't have to do these operations for each patient
@sainak do you mean creating a Boolean field on consultation model that is changed with consent operations? |
yes |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2255 +/- ##
===========================================
+ Coverage 63.48% 63.55% +0.06%
===========================================
Files 238 238
Lines 13264 13298 +34
Branches 1886 1892 +6
===========================================
+ Hits 8421 8451 +30
- Misses 4490 4492 +2
- Partials 353 355 +2 ☔ View full report in Codecov by Sentry. |
@sainak need another review and we are good to go |
Proposed Changes
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins