Running knex migrations

[carlosfaria94]

Hi, first of all, thank you for this amazing package!

I configured pg-mem with knex, like this:

  const mem = newDb()
  knex = mem.adapters.createKnex(0, {
    ...databaseOpts,
    ...knexSnakeCaseMappers(),
  })

And then I executed await knex.migrate.latest(), starting all migration files. But it fails in the first migration:

import * as Knex from 'knex'

export async function up(knex: Knex): Promise<void> {
  return knex.schema
    .createTable('update_times', function (table) {
      table.string('id', 50).unique().notNullable().primary()
      table.dateTime('update_time').notNullable()
    })
    .createTable('room_board_types', function (table) {
      table.string('id', 2).unique().notNullable().primary()
      table.string('name', 100).notNullable()
      table.boolean('enabled').notNullable().defaultTo(false)
      table.boolean('package').notNullable().defaultTo(false)
    })
    .createTable('room_types', function (table) {
      table.string('id', 3).unique().notNullable().primary()
      table.string('name', 100).notNullable()
      table.boolean('enabled').notNullable().defaultTo(false)
      table.boolean('package').notNullable().defaultTo(false)
    })
    .createTable('room_characteristics', function (table) {
      table.string('id', 10).unique().notNullable().primary()
      table.string('name', 100).nullable()
      table.boolean('enabled').notNullable().defaultTo(true)
    })
    .createTable('room_types_characteristics', function (table) {
      table.string('type_id', 3).notNullable().references('id').inTable('room_types')
      table.string('characteristic_id', 10).notNullable().references('id').inTable('room_characteristics')
      table.primary(['type_id', 'characteristic_id'])
    })
}

export async function down(knex: Knex): Promise<void> {
  return knex.schema
    .dropTableIfExists('room_types_characteristics')
    .dropTableIfExists('room_characteristics')
    .dropTableIfExists('room_types')
    .dropTableIfExists('room_board_types')
    .dropTableIfExists('update_times')
}

And then I get the following error from pg-mem:

🔨 Not supported 🔨 : get pg fields

What I'm doing wrong?

Thanks

[oguimbal]

Hi !
You are doing nothing wrong... knexSnakeCaseMappers() is just reading a field that is not supported.

Fix shipped with [email protected] !

And thanks for the kind words

[carlosfaria94]

It solved the problem, thank you!

[carlosfaria94]

@oguimbal but I'm now getting another error, should I create a new issue or discussion?

I think knex generates SQL that is not compatible with pg-mem:

    SAVEPOINT trx3; - 💔 Your query failed to parse.
    This is most likely due to a SQL syntax error. However, you might also have hit a bug, or an unimplemented feature of pg-mem.
    If this is the case, please file an issue at https://github.com/oguimbal/pg-mem along with a query that reproduces this syntax error.

    👉 Failed query:

        SAVEPOINT trx3;;

    💀 Syntax error at line 1 col 11:

      SAVEPOINT trx3
                ^
    Unexpected word token: "trx3". I did not expect any more input. Here is the state of my parse table:

        kw_truncate → %word ●
        kw_delete → %word ●
        kw_start → %word ●
        kw_insert → %word ●
        kw_begin → %word ●
        kw_show → %word ●
        kw_set → %word ●
        kw_tablespace → %word ●
        kw_rollback → %word ●
        kw_commit → %word ●
        kw_comment → %word ●
        kw_raise → %word ●
        kw_drop → %word ●
        kw_alter → %word ●
        kw_update → %word ●
        kw_prepare → %word ●

      at Object.parseSql (node_modules/pg-mem/src/parse-cache.ts:53:15)
      at DbSchema.parse (node_modules/pg-mem/src/schema.ts:97:16)
      at DbSchema.queries (node_modules/pg-mem/src/schema.ts:105:31)
          at queries.next (<anonymous>)
      at DbSchema.query (node_modules/pg-mem/src/schema.ts:84:20)
      at MemPg.query (node_modules/pg-mem/src/adapters.ts:114:76)
      at node_modules/knex/lib/dialects/postgres/index.js:237:18
      at Client_PG._query (node_modules/knex/lib/dialects/postgres/index.js:236:12)
      at Client_PG.query (node_modules/knex/lib/client.js:168:17)

[jd1378]

hi @oguimbal
the error with SAVEPOINT trx3 still exists a few years later
any chance it is going to be supported ?