Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignalHandler: specify the logger that will log the error #590

Closed
odygrd opened this issue Sep 24, 2024 · 0 comments · Fixed by #595
Closed

SignalHandler: specify the logger that will log the error #590

odygrd opened this issue Sep 24, 2024 · 0 comments · Fixed by #595
Labels
enhancement New feature or request

Comments

@odygrd
Copy link
Owner

odygrd commented Sep 24, 2024

  1. Pass a logger name when the backend is setup that will be used to log the error in the signal handler. If not found then fallback to the first valid logger to log it
  2. remove start_with_signal_handler function, this can be moved to BackendOptions with all the additional signal handler config params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SignalHandlerOptions, deprecate start_with_signal_handler odygrd/quill
1 participant
@odygrd