Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error on x86 macOS #360

Closed
pablode opened this issue Oct 18, 2023 · 4 comments · Fixed by #366
Closed

Build error on x86 macOS #360

pablode opened this issue Oct 18, 2023 · 4 comments · Fixed by #366

Comments

@pablode
Copy link

pablode commented Oct 18, 2023

Hello! Trying to compile Quill v3.3.1 with Xcode 12.4 on Catalina 10.15.7 results in following compilation error:

[1/60] Building CXX object extern/quill/quill/CMakeFiles/quill.dir/src/detail/misc/RdtscClock.cpp.o
FAILED: extern/quill/quill/CMakeFiles/quill.dir/src/detail/misc/RdtscClock.cpp.o
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -I/Users/pablode/Dropbox/projects/gatling/extern/quill/quill/include -I/Users/pablode/Dropbox/projects/gatling/extern/quill/quill -O2 -g  -std=c++2a -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -mmacosx-version-min=10.15 -fPIC -Wall -Wextra -Wconversion -pedantic -Wfatal-errors -Wno-unused-private-field -Wno-gnu-zero-variadic-macro-arguments -Wno-unused-parameter -MD -MT extern/quill/quill/CMakeFiles/quill.dir/src/detail/misc/RdtscClock.cpp.o -MF extern/quill/quill/CMakeFiles/quill.dir/src/detail/misc/RdtscClock.cpp.o.d -o extern/quill/quill/CMakeFiles/quill.dir/src/detail/misc/RdtscClock.cpp.o -c /Users/pablode/Dropbox/projects/gatling/extern/quill/quill/src/detail/misc/RdtscClock.cpp
In file included from /Users/pablode/Dropbox/projects/gatling/extern/quill/quill/src/detail/misc/RdtscClock.cpp:3:
/Users/pablode/Dropbox/projects/gatling/extern/quill/quill/include/quill/detail/misc/Rdtsc.h:19:14: fatal error: 'x86gprintrin.h' file not found
    #include <x86gprintrin.h>
             ^~~~~~~~~~~~~~~~
1 error generated.

ll /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/12.0.0/include/

Result
total 2400
-rw-r--r--   3 root  wheel   4.6K Dec 16  2020 __clang_cuda_builtin_vars.h
-rw-r--r--   3 root  wheel    17K Dec 21  2020 __clang_cuda_cmath.h
-rw-r--r--   3 root  wheel   7.4K Dec 22  2020 __clang_cuda_complex_builtins.h
-rw-r--r--   3 root  wheel    70K Dec 21  2020 __clang_cuda_device_functions.h
-rw-r--r--   3 root  wheel    22K Dec 22  2020 __clang_cuda_intrinsics.h
-rw-r--r--   3 root  wheel    22K Dec 21  2020 __clang_cuda_libdevice_declares.h
-rw-r--r--   3 root  wheel   9.1K Dec 22  2020 __clang_cuda_math_forward_declares.h
-rw-r--r--   3 root  wheel    15K Dec 21  2020 __clang_cuda_runtime_wrapper.h
-rw-r--r--   1 root  wheel   857B Dec 16  2020 __stddef_max_align_t.h
-rw-r--r--   3 root  wheel   5.1K Dec 22  2020 __wmmintrin_aes.h
-rw-r--r--   1 root  wheel   2.0K Dec 16  2020 __wmmintrin_pclmul.h
-rw-r--r--   1 root  wheel   2.3K Dec 16  2020 adxintrin.h
-rw-r--r--   3 root  wheel   595K Dec 22  2020 altivec.h
-rw-r--r--   3 root  wheel   7.4K Dec 22  2020 ammintrin.h
-rw-r--r--   1 root  wheel   993B Dec 16  2020 arm64intr.h
-rw-r--r--   3 root  wheel    22K Dec 21  2020 arm_acle.h
-rw-r--r--   3 root  wheel   6.2K Dec 22  2020 arm_cmse.h
-rw-r--r--   3 root  wheel    17K Dec 22  2020 arm_fp16.h
-rw-r--r--   3 root  wheel   836K Dec 22  2020 arm_mve.h
-rw-r--r--   3 root  wheel   2.1M Dec 22  2020 arm_neon.h
-rw-r--r--   1 root  wheel   843B Dec 16  2020 armintr.h
-rw-r--r--   3 root  wheel    38K Dec 21  2020 avx2intrin.h
-rw-r--r--   3 root  wheel    10K Dec 21  2020 avx512bf16intrin.h
-rw-r--r--   1 root  wheel   2.4K Dec 16  2020 avx512bitalgintrin.h
-rw-r--r--   3 root  wheel    75K Dec 21  2020 avx512bwintrin.h
-rw-r--r--   3 root  wheel   4.1K Dec 21  2020 avx512cdintrin.h
-rw-r--r--   3 root  wheel    58K Dec 16  2020 avx512dqintrin.h
-rw-r--r--   3 root  wheel    12K Dec 22  2020 avx512erintrin.h
-rw-r--r--   3 root  wheel   377K Dec 21  2020 avx512fintrin.h
-rw-r--r--   1 root  wheel   2.5K Dec 16  2020 avx512ifmaintrin.h
-rw-r--r--   3 root  wheel   4.4K Dec 22  2020 avx512ifmavlintrin.h
-rw-r--r--   3 root  wheel   4.5K Dec 22  2020 avx512pfintrin.h
-rw-r--r--   3 root  wheel    13K Dec 22  2020 avx512vbmi2intrin.h
-rw-r--r--   1 root  wheel   3.7K Dec 16  2020 avx512vbmiintrin.h
-rw-r--r--   3 root  wheel   6.9K Dec 22  2020 avx512vbmivlintrin.h
-rw-r--r--   3 root  wheel    18K Dec 21  2020 avx512vlbf16intrin.h
-rw-r--r--   3 root  wheel   4.2K Dec 22  2020 avx512vlbitalgintrin.h
-rw-r--r--   3 root  wheel   110K Dec 21  2020 avx512vlbwintrin.h
-rw-r--r--   3 root  wheel   7.7K Dec 22  2020 avx512vlcdintrin.h
-rw-r--r--   3 root  wheel    46K Dec 16  2020 avx512vldqintrin.h
-rw-r--r--   3 root  wheel   322K Dec 22  2020 avx512vlintrin.h
-rw-r--r--   3 root  wheel    26K Dec 22  2020 avx512vlvbmi2intrin.h
-rw-r--r--   3 root  wheel   7.9K Dec 22  2020 avx512vlvnniintrin.h
-rw-r--r--   3 root  wheel   4.4K Dec 21  2020 avx512vlvp2intersectintrin.h
-rw-r--r--   3 root  wheel   4.2K Dec 16  2020 avx512vnniintrin.h
-rw-r--r--   1 root  wheel   2.9K Dec 16  2020 avx512vp2intersectintrin.h
-rw-r--r--   1 root  wheel   2.0K Dec 16  2020 avx512vpopcntdqintrin.h
-rw-r--r--   1 root  wheel   3.3K Dec 16  2020 avx512vpopcntdqvlintrin.h
-rw-r--r--   3 root  wheel   194K Dec 21  2020 avxintrin.h
-rw-r--r--   1 root  wheel   2.3K Dec 16  2020 bmi2intrin.h
-rw-r--r--   3 root  wheel    12K Dec 21  2020 bmiintrin.h
-rw-r--r--   1 root  wheel   2.8K Dec 16  2020 cetintrin.h
-rw-r--r--   1 root  wheel   881B Dec 21  2020 cldemoteintrin.h
-rw-r--r--   1 root  wheel   861B Dec 16  2020 clflushoptintrin.h
-rw-r--r--   1 root  wheel   1.2K Dec 16  2020 clwbintrin.h
-rw-r--r--   1 root  wheel   1.1K Dec 16  2020 clzerointrin.h
-rw-r--r--   3 root  wheel    10K Dec 22  2020 cpuid.h
drwxr-xr-x   5 root  wheel   160B Dec 21  2020 cuda_wrappers
-rw-r--r--   3 root  wheel   181K Dec 21  2020 emmintrin.h
-rw-r--r--   1 root  wheel   2.1K Dec 16  2020 enqcmdintrin.h
-rw-r--r--   3 root  wheel   5.4K Dec 16  2020 f16cintrin.h
-rw-r--r--   3 root  wheel   4.6K Dec 22  2020 float.h
-rw-r--r--   3 root  wheel   6.8K Dec 21  2020 fma4intrin.h
-rw-r--r--   3 root  wheel   6.8K Dec 21  2020 fmaintrin.h
drwxr-xr-x   3 root  wheel    96B Dec 22  2020 fuzzer
-rw-r--r--   1 root  wheel   2.8K Dec 16  2020 fxsrintrin.h
-rw-r--r--   3 root  wheel   7.7K Dec 16  2020 gfniintrin.h
-rw-r--r--   3 root  wheel   6.1K Dec 16  2020 htmintrin.h
-rw-r--r--   3 root  wheel   9.0K Dec 16  2020 htmxlintrin.h
-rw-r--r--   3 root  wheel    13K Dec 21  2020 ia32intrin.h
-rw-r--r--   3 root  wheel    16K Dec 22  2020 immintrin.h
-rw-r--r--   3 root  wheel    26K Dec 21  2020 intrin.h
-rw-r--r--   1 root  wheel   2.3K Dec 16  2020 inttypes.h
-rw-r--r--   1 root  wheel   764B Dec 16  2020 invpcidintrin.h
-rw-r--r--   1 root  wheel   656B Dec 16  2020 iso646.h
-rw-r--r--   1 root  wheel   2.8K Dec 16  2020 limits.h
-rw-r--r--   3 root  wheel   5.0K Dec 16  2020 lwpintrin.h
-rw-r--r--   1 root  wheel   3.2K Dec 16  2020 lzcntintrin.h
-rw-r--r--   3 root  wheel   4.5K Dec 21  2020 mm3dnow.h
-rw-r--r--   1 root  wheel   1.7K Dec 16  2020 mm_malloc.h
-rw-r--r--   3 root  wheel    56K Dec 22  2020 mmintrin.h
-rw-r--r--   3 root  wheel   5.2K Dec 22  2020 module.modulemap
-rw-r--r--   1 root  wheel   1.6K Dec 16  2020 movdirintrin.h
-rw-r--r--   3 root  wheel    25K Dec 22  2020 msa.h
-rw-r--r--   1 root  wheel   1.1K Dec 16  2020 mwaitxintrin.h
-rw-r--r--   1 root  wheel   580B Dec 16  2020 nmmintrin.h
-rw-r--r--   3 root  wheel    21K Dec 21  2020 opencl-c-base.h
-rw-r--r--   3 root  wheel   799K Dec 21  2020 opencl-c.h
drwxr-xr-x   6 root  wheel   192B Dec 21  2020 openmp_wrappers
-rw-r--r--   1 root  wheel   1.2K Dec 16  2020 pconfigintrin.h
-rw-r--r--   1 root  wheel   934B Dec 16  2020 pkuintrin.h
-rw-r--r--   3 root  wheel    10K Dec 22  2020 pmmintrin.h
-rw-r--r--   1 root  wheel   1.6K Dec 16  2020 popcntintrin.h
drwxr-xr-x   9 root  wheel   288B Jan  9  2021 ppc_wrappers
-rw-r--r--   1 root  wheel   1.9K Dec 16  2020 prfchwintrin.h
drwxr-xr-x   3 root  wheel    96B Dec 22  2020 profile
-rw-r--r--   3 root  wheel    21K Dec 21  2020 ptrauth.h
-rw-r--r--   1 root  wheel   1.1K Dec 16  2020 ptwriteintrin.h
-rw-r--r--   1 root  wheel   1.2K Dec 16  2020 rdseedintrin.h
-rw-r--r--   1 root  wheel   1.2K Dec 16  2020 rtmintrin.h
-rw-r--r--   1 root  wheel   604B Dec 16  2020 s390intrin.h
drwxr-xr-x  16 root  wheel   512B Dec 22  2020 sanitizer
-rw-r--r--   1 root  wheel   1.8K Dec 16  2020 sgxintrin.h
-rw-r--r--   1 root  wheel   1.9K Dec 16  2020 shaintrin.h
-rw-r--r--   3 root  wheel    99K Dec 21  2020 smmintrin.h
-rw-r--r--   1 root  wheel   583B Dec 16  2020 stdalign.h
-rw-r--r--   1 root  wheel   1.1K Dec 16  2020 stdarg.h
-rw-r--r--   3 root  wheel   7.1K Dec 21  2020 stdatomic.h
-rw-r--r--   1 root  wheel   897B Dec 16  2020 stdbool.h
-rw-r--r--   1 root  wheel   3.5K Dec 16  2020 stddef.h
-rw-r--r--   3 root  wheel    22K Dec 16  2020 stdint.h
-rw-r--r--   1 root  wheel   510B Dec 16  2020 stdnoreturn.h
-rw-r--r--   1 root  wheel   3.1K Dec 16  2020 tbmintrin.h
-rw-r--r--   3 root  wheel    30K Dec 22  2020 tgmath.h
-rw-r--r--   3 root  wheel    29K Dec 16  2020 tmmintrin.h
-rw-r--r--   3 root  wheel    11K Dec 16  2020 unwind.h
-rw-r--r--   1 root  wheel   1.4K Dec 16  2020 vadefs.h
-rw-r--r--   1 root  wheel   2.4K Dec 16  2020 vaesintrin.h
-rw-r--r--   1 root  wheel   477B Dec 16  2020 varargs.h
-rw-r--r--   3 root  wheel   341K Dec 21  2020 vecintrin.h
-rw-r--r--   1 root  wheel   1.0K Dec 16  2020 vpclmulqdqintrin.h
-rw-r--r--   1 root  wheel   1.3K Dec 16  2020 waitpkgintrin.h
-rw-r--r--   1 root  wheel   749B Dec 16  2020 wbnoinvdintrin.h
-rw-r--r--   1 root  wheel   530B Dec 16  2020 wmmintrin.h
-rw-r--r--   1 root  wheel   1.4K Dec 21  2020 x86intrin.h
-rw-r--r--   3 root  wheel   106K Dec 21  2020 xmmintrin.h
-rw-r--r--   3 root  wheel    20K Dec 22  2020 xopintrin.h
-rw-r--r--   1 root  wheel   1.0K Dec 16  2020 xsavecintrin.h
-rw-r--r--   1 root  wheel   1.6K Dec 16  2020 xsaveintrin.h
-rw-r--r--   1 root  wheel   1.0K Dec 16  2020 xsaveoptintrin.h
-rw-r--r--   1 root  wheel   1.2K Dec 16  2020 xsavesintrin.h
-rw-r--r--   1 root  wheel   873B Dec 16  2020 xtestintrin.h
@odygrd
Copy link
Owner

odygrd commented Oct 31, 2023

hey, thanks for reporting. The CI runs on big sur and i also don't have Catalina on my personal computer.
https://github.com/odygrd/quill/actions/runs/6713304826

Can you try to change in line
https://github.com/odygrd/quill/blob/master/quill/include/quill/detail/misc/Rdtsc.h#L18

the condition from __clang_major__ > 11 to __clang_major__ > 12 and let me know if that works ?

@odygrd
Copy link
Owner

odygrd commented Nov 3, 2023

this PR is attempting to fix this #366
I do not have access to apple clang 12.0.0 compiler. Please let me know if there is still an issue

@odygrd odygrd linked a pull request Nov 3, 2023 that will close this issue
@pablode
Copy link
Author

pablode commented Nov 3, 2023

Hi! Sorry for the delay. I just tested the PR and it works. Thanks!

@odygrd
Copy link
Owner

odygrd commented Nov 3, 2023

Thanks a lot for confirming !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants