Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

nodejs catalog entry only works with apps that bind to port 3000 #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryanj
Copy link

@ryanj ryanj commented Feb 12, 2021

Including an optional "Route" that is hard-coded to 3000 is a risky assumption for a catalog example.

Feel free to close this issue if the default nodejs example is only expected to be used with the --starter repo.

Expected impact of this change:

  • No route creation by default. After this change, catalog users will need to run odo url create --port 3000 (or similar) as a separate step before connecting to the default nodejs example. This makes the user-experience one step longer, but it would allow the reference catalog example to be used with applications that do not bind to 3000 by default.
  • Users with apps that bind to 8080 can successfully use the default catalog entry for nodejs. If they would like to expose a route, they can do so by running odo url create --port 8080.

@ryanj ryanj closed this Feb 15, 2021
@ryanj ryanj reopened this Feb 15, 2021
@ryanj ryanj changed the title hard-coding this option at 3000 breaks a lot of examples nodejs catalog entry only works with apps that bind to port 3000 Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant