This repository has been archived by the owner on May 11, 2021. It is now read-only.
nodejs catalog entry only works with apps that bind to port 3000 #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including an optional "Route" that is hard-coded to 3000 is a risky assumption for a catalog example.
Feel free to close this issue if the default nodejs example is only expected to be used with the --starter repo.
Expected impact of this change:
odo url create --port 3000
(or similar) as a separate step before connecting to the default nodejs example. This makes the user-experience one step longer, but it would allow the reference catalog example to be used with applications that do not bind to 3000 by default.8080
can successfully use the default catalog entry for nodejs. If they would like to expose a route, they can do so by runningodo url create --port 8080
.