Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make $form['#action'] = 'dispatch-data/run_analysis' configurable in instruments #193

Open
dsavchenko opened this issue Mar 6, 2023 · 10 comments
Assignees

Comments

@dsavchenko
Copy link
Member

Needed for frontend installations, which asks different dispatchers

@volodymyrss
Copy link
Member

should we ask @motame to do this, what do you think?

@dsavchenko
Copy link
Member Author

It's easy enough so that anyone of us can do it. But as @motame should review anyway, probably he can just do it quickly.

@motame
Copy link
Contributor

motame commented Apr 18, 2023

A new config parameter is added: data_server_local_url.
'data_server_local_url' => 'dispatch-data/run_analysis'
Note that it's better to consider only local paths (web server aliases).
If an external provider is needed, a proxy should configured in the web server configuration e.g.
ProxyPass /mmoda/dispatch-data/ https://frontend-prod.obsuks1.unige.ch/mmoda/dispatch-data/

@dsavchenko
Copy link
Member Author

Small concern about naming: it was meant to be used with external dispatcher, so local could be misleading.
On the other hand, if you advise using proxy for this (why?) then the name is ok (meaning local vs global)

@volodymyrss
Copy link
Member

I guess this name is meant to be rather "relative" than local?

@motame
Copy link
Contributor

motame commented Apr 18, 2023

local here is for "local web server path/alias" which can be indeed an alias to a local service (less probable in our case) or a proxypass to an external url as shown above.
And Indeed, @dsavchenko, I advise using proxypass to avoid issues with CORS, Cross-Origin Resource Sharing.
Allowing the page to make XMLHttpRequest directly from external services may raise security issues !

@dsavchenko
Copy link
Member Author

I didn't think about CORS. Thanks !

@volodymyrss
Copy link
Member

is this over @dsavchenko ?

@dsavchenko
Copy link
Member Author

is this over @dsavchenko ?

Seems that. I didn't try it “in the wild”, though.

@motame
Copy link
Contributor

motame commented Jun 5, 2023

Yes it is !
And pushed to github reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants