Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site title should be inverted on homepage #31

Open
sarahmonster opened this issue Dec 29, 2019 · 1 comment
Open

Site title should be inverted on homepage #31

sarahmonster opened this issue Dec 29, 2019 · 1 comment
Assignees

Comments

@sarahmonster
Copy link
Member

sarahmonster commented Dec 29, 2019

Basically so this:

Welcome! · My Site

becomes

My Site · Welcome!

See https://github.com/octopusthink/octopusthink.com/pull/92 for some context.

octopusthink.com does this by passing a homepage prop to the SEO component, which works because the homepage is using a different template than the other pages. So we basically have two options here:

  1. Always use a separate template for the homepage. (Increases complexity needlessly for some uses.)
  2. Dynamically determine if we're on the homepage (maybe by inspecting the URL or the source filename?) and page the prop accordingly.

No. 2 seems like the much less fragile option here, but if it isn't a possible technically a better alternative might be to manually set a "homepage" flag to true in the homepage's front matter.

@sarahmonster
Copy link
Member Author

@tofumatt do you know if there's a technically feasible way to accomplish no.2 on this list, or should I just opt for a no1-based solution?

@tofumatt tofumatt self-assigned this May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants