-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Upgrade .gitignore
to latest
#325
Conversation
Removed a few ignores such as the '.nupkg' ignore since this would conflict with the NuGet package in the 'lib' directory Signed-off-by: Lamparter <[email protected]>
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Thanks for this change... would you also mind updating |
Signed-off-by: Lamparter <[email protected]>
Signed-off-by: Lamparter <[email protected]>
Fyi, I did this in other pr. The pr that contains the move to src dir. |
Yeah I think @nickfloyd just means they want to see the build result here 😅 |
Removed a few ignores such as the '.nupkg' ignore since this would conflict with the NuGet package in the 'lib' directory
Before the change?
.gitignore
was the visual studio ignore at the time of project initialisationAfter the change?
This is a pretty minor code quality change but it's good to update files like these to future-proof the repo and prevent any accidents.
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!