Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default IssueFilters instance shouldn't exclude any issues #235

Open
terrajobst opened this issue Jul 1, 2020 · 2 comments
Open

Default IssueFilters instance shouldn't exclude any issues #235

terrajobst opened this issue Jul 1, 2020 · 2 comments
Labels
Type: Bug Something isn't working as documented

Comments

@terrajobst
Copy link

A default instance of IssueFilter has all properties set to null, which in the resulting graph query will compare all the fields to null. However, this means it looks for issues which have no milestone and no assignee. Since "*" includes all issues, I suggest that IssueFilter initializes Milestone and Assignee to "*".

@github-actions
Copy link

github-actions bot commented Dec 3, 2022

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Dec 3, 2022
@kfcampbell kfcampbell added Priority: Normal Type: Bug Something isn't working as documented labels Dec 5, 2022
@github-actions github-actions bot removed the Status: Stale Used by stalebot to clean house label Dec 6, 2022
@hartez
Copy link

hartez commented Jan 18, 2023

A default instance of IssueFilter has all properties set to null, which in the resulting graph query will compare all the fields to null. However, this means it looks for issues which have no milestone and no assignee. Since "*" includes all issues, I suggest that IssueFilter initializes Milestone and Assignee to "*".

As far as I can tell, * does not return any issue which doesn't have a value for the specified field. So null for Milestone doesn't match any issues with milestones assigned, and * doesn't match issues which don't have any milestones. So either way, issues are being excluded. It feels like there should be some way to get issues regardless of whether they have a milestone or assignee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

No branches or pull requests

4 participants