-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why optimal transport matrix is not used? #13
Comments
@HannesStark Considering the sad news of Octavian, we are not sure who can answer this question, could you please help us to clarify this point? |
Hi! |
Hi Hannes, thanks so much for your kind & quick response! Please allow me to discuss this point further. As far as our team understand, by using Since Kabsch algorithm seems to assume perfect-aligned points (i.e. one-to-one correspondence between two sets), I still not quite clear that |
Hey!
|
Hi, thanks for the great work!! I have a question regarding the following point in the paper:
On p.7 it is stated that:
However, in the code here :
https://github.com/octavian-ganea/equidock_public/blob/main/src/train.py#L128
The optimal transport matrix (the 2nd returned variable) is ignored:
ot_dist, _ = compute_ot_emd(cost_mat_ligand + cost_mat_receptor, args['device'])
In my understanding, the matrix should be used to recovered the alignment.
So I am now confused how the points alignment can be recovered without this optimal transport matrix?
Thank you so much again!
The text was updated successfully, but these errors were encountered: