Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: signDDO #1877

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

chore: signDDO #1877

wants to merge 10 commits into from

Conversation

AdriGeorge
Copy link
Collaborator

Changes proposed in this PR:

  • Sign credential with waltId
  • Sign credential with private key

paulo-ocean
paulo-ocean reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we know if the functions like signCredential and signCredentialWithWaltId actually do what's expected? I don't see any usage of these, no unit tests, etc? And the 'privateKey' is supposed to be sent clear text? (i don't think we have any similar case)

@jamiehewitt15
Copy link
Member

You haven't referenced an issue, and there is also no documentation on any of these changes, so it is difficult to review and evaluate whether the original objective has been met.

@AdriGeorge AdriGeorge linked an issue Nov 21, 2024 that may be closed by this pull request
Sign Verifiable Credential #1878
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean left review comments

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc is a code owner

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sign Verifiable Credential
3 participants
@AdriGeorge @jamiehewitt15 @paulo-ocean