Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with-kinds #3284

Draft
wants to merge 4 commits into
base: rae/const-sorts-in-transl
Choose a base branch
from
Draft

with-kinds #3284

wants to merge 4 commits into from

Conversation

goldfirere
Copy link
Collaborator

This adds with-kinds to the compiler.

It is a very preliminary version. Importantly, you should not use an actual with-kind in your code and expect anything to work. Instead, this just provides inferred with-kinds, but that should be sufficient for looking through lists, options, and arrays.

As of this posting, the work here is still not tested, but it may bootstrap. (Actually, the bootstrap test was without the final commit.) More action here soon.

Copy link

Parser Change Checklist

This PR modifies the parser. Please check that the following tests are updated:

  • parsetree/source_jane_street.ml

This test should have examples of every new bit of syntax you are adding. Feel free to just check the box if your PR does not actually change the syntax (because it is refactoring the parser, say).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant