Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A number of parallel benchmarks seem to be broken #446

Open
kayceesrk opened this issue Apr 24, 2023 · 2 comments
Open

A number of parallel benchmarks seem to be broken #446

kayceesrk opened this issue Apr 24, 2023 · 2 comments

Comments

@kayceesrk
Copy link
Contributor

image

Corresponding sandmark nightly run

@punchagan
Copy link
Contributor

The benchmarks that are broken here are the MPL benchmarks added in #404 & #439. The benchmarks are broken due to missing serial versions of the benchmarks as noted in the comment here: #439 (comment)

@shwestrick
Copy link

shwestrick commented May 26, 2023

It should be easy to generate a sequential version of the MPL benchmarks. Just need to replace the ForkJoin module with an equivalent sequential implementation. All parallelism goes through that module.

E.g. let par f g = (f(), g()) and similarly for the other functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants