Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Additional Api Parameters? #7

Open
dreadjr opened this issue Apr 9, 2015 · 6 comments
Open

Pass Additional Api Parameters? #7

dreadjr opened this issue Apr 9, 2015 · 6 comments
Assignees

Comments

@dreadjr
Copy link

dreadjr commented Apr 9, 2015

How do I add extra parameters to api calls.

For example for Person

fc.person.email('[email protected]', 'queue', 'webhookUrl', 'webhookId', function(err, data) {
});

But i can't pass any extra arguments, like style or css, etc. Maybe just moving to a

var options = {
  email: '123',
  emailMD5: '',
  etc...
};
fc.person.email(options)

@3rd-Eden
Copy link
Member

3rd-Eden commented Apr 9, 2015

I don't think that's currently possible in the implementation. The API I would suggest would be..

fullcontact.person.email('required email value', { optional options }, function () {

});

But I don't know if I have the time to implement this, so i'm accepting pull requests for this feature request.

@dreadjr
Copy link
Author

dreadjr commented Apr 9, 2015

Ok, yeah I didn't see a way in the code, i'll see if I have time to implement this and submit a pull request.

@AdriVanHoudt
Copy link
Contributor

We could have 1 argument that's an options object and validate it has no invalid options for that route, would be more flexible than the current implementation of the webhookUrl for example where you have to pass null as que if you only want the webhook.

@wlaurance
Copy link

👍 it would be great to add in things like keyPeople: true for the Company API

@AdriVanHoudt
Copy link
Contributor

What does that param do?

@AdriVanHoudt AdriVanHoudt mentioned this issue May 15, 2017
@AdriVanHoudt
Copy link
Contributor

Latests proposal from @3rd-Eden is

fullcontact.person.email('[email protected]', { 
  macromeasures: true,
   webhookId:'id here' 
}, fn);

PR's very welcome!
If you need any help let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants