Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove observing api key from package.json #31

Open
Skiggz opened this issue Jun 8, 2017 · 2 comments
Open

Remove observing api key from package.json #31

Skiggz opened this issue Jun 8, 2017 · 2 comments

Comments

@Skiggz
Copy link

Skiggz commented Jun 8, 2017

The observing account's api key was found in package.json here:

https://github.com/observing/fullcontact/blob/master/package.json#L14

This should perhaps be placeholder text the readme specifies to change, or an environment variable for the script to reference per user rather than sharing a key from your account in the open source library. That key has been disabled for that account's security in case it was by accident.

If you do however want to share a key, which I'd advise against, that key has been disabled so you'll need to update it to the new one in your account, but again I'd suggest just instructing users to use their own as any kind of weirdness from keys could trigger it being flagged or disabled in the future again anyways.

cc @3rd-Eden

@AdriVanHoudt
Copy link
Contributor

I think this was intentional but probably better off using travis secrets or something indeed

@Skiggz
Copy link
Author

Skiggz commented Jun 8, 2017

Yeah at least so somebody doesn't decide to use it, get it flagged, and then it doesn't work for anyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants