Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove part_of o develops_from -> develops_from injection #3197

Closed
wants to merge 1 commit into from

Conversation

anitacaron
Copy link
Collaborator

Fixes #2723

@anitacaron anitacaron self-assigned this Feb 5, 2024
@anitacaron
Copy link
Collaborator Author

#gogoeditdiff

@gouttegd
Copy link
Collaborator

gouttegd commented Feb 5, 2024

The “gogoeditdiff“ action failed to post the diff because it is too large (comments are apparently limited to 64 KB). Here’s the diff: simple-report.md

The few changes I’ve looked at seem exactly the kind of changes we’d expect upon removal of the chain.

@cmungall
Copy link
Member

cmungall commented Feb 5, 2024

this shouldn't happen:

upper jaw region http://purl.obolibrary.org/obo/UBERON_0001709

Removed

Copy link
Member

@balhoff balhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion with @cmungall @anitacaron @matentzn:

  • add property chain 'has part' o 'has developmental contribution from' -> 'has developmental contribution from' (edit existing which I think uses 'develops from')
  • remove "derived" probe classes (e.g. "ectoderm-derived structure", and other germ layers)

@anitacaron
Copy link
Collaborator Author

add property chain 'has part' o 'has developmental contribution from' -> 'has developmental contribution from' (edit existing which I think uses 'develops from')

This property chain is in RO, so the change needs to be done there. I'll create an issue there.

@gouttegd
Copy link
Collaborator

gouttegd commented Feb 5, 2024

@anitacaron I presume you intend to take care of the second action item (“remove "derived" probe classes (e.g. "ectoderm-derived structure", and other germ layers)”) in a separate PR?

If so, looks good to me here, given that the other item needs to happen elsewhere.

Copy link
Collaborator

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a bit weird that we now have an entire component for just one axiom, but oh well, that’s not the weirdest thing in Uberon!

Copy link

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

@dosumis
Copy link
Contributor

dosumis commented Apr 15, 2024

Discussing this on a call. We are unsure why this property chain is being removed (apart from that it ultimately should come from RO. It is doing useful work for inference that we likely can't effectively manage by hand. ALso note - we seem to have effectively the same axiomatisation via the subproperty of develops_from: develops_from_part_of https://www.ebi.ac.uk/ols4/ontologies/clo/properties/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FRO_0002225 - shouldn't this suffice to give the inference we need, and if it currently does not, why not?

(Note - the other property chain 'develops_from o part_of --> develops_from should be removed - has_developmental_contribution_from is sufficient).

Copy link

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

Copy link

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

@gouttegd
Copy link
Collaborator

In the last RO call it was decided to test the various combinations of actions regarding the injected chains (remove both, remove one, remove the other) and have a look at the corresponding diffs to better understand the consequences of each chain and of their removal.

@gouttegd gouttegd closed this Dec 14, 2024
@gouttegd gouttegd deleted the anitacaron/issue2723 branch December 14, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove property chain injection
5 participants