You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After struggling for a while to make some animations work in Loki, I noticed that passing the chromeEnableAnimations flag doesn't have any effect. It appears that the flag is not currently being passed to Chrome due to missing configuration.
Expected Behavior
Passing the chromeEnableAnimations flag should enable animations when taking screenshots in Chrome.
Current Behavior
There's no difference in behavior regardless of whether the chromeEnableAnimations flag is passed.
Possible Solution
Add the missing line to create-chrome-target.js:
lettabOptions=Object.assign({media: options.chromeEmulatedMedia,fetchFailIgnore: options.fetchFailIgnore,chromeEnableAnimations: options.chromeEnableAnimations// this line},configuration,parameters.loki||{});
Steps to Reproduce
Attempt to pass the chromeEnableAnimations flag to Loki.
Observe that animations are not enabled.
Context (Environment)
Loki Version: 0.35.0
Node Version: 18.5.0
The text was updated successfully, but these errors were encountered:
Description
After struggling for a while to make some animations work in Loki, I noticed that passing the
chromeEnableAnimations
flag doesn't have any effect. It appears that the flag is not currently being passed to Chrome due to missing configuration.Expected Behavior
Passing the
chromeEnableAnimations
flag should enable animations when taking screenshots in Chrome.Current Behavior
There's no difference in behavior regardless of whether the
chromeEnableAnimations
flag is passed.Possible Solution
Add the missing line to
create-chrome-target.js
:Steps to Reproduce
chromeEnableAnimations
flag to Loki.Context (Environment)
The text was updated successfully, but these errors were encountered: