Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromeEnableAnimations flag is not passed down as tabOptions #517

Open
Hardru opened this issue May 8, 2024 · 0 comments
Open

chromeEnableAnimations flag is not passed down as tabOptions #517

Hardru opened this issue May 8, 2024 · 0 comments

Comments

@Hardru
Copy link

Hardru commented May 8, 2024

Description

After struggling for a while to make some animations work in Loki, I noticed that passing the chromeEnableAnimations flag doesn't have any effect. It appears that the flag is not currently being passed to Chrome due to missing configuration.

Expected Behavior

Passing the chromeEnableAnimations flag should enable animations when taking screenshots in Chrome.

Current Behavior

There's no difference in behavior regardless of whether the chromeEnableAnimations flag is passed.

Possible Solution

Add the missing line to create-chrome-target.js:

let tabOptions = Object.assign(
  {
    media: options.chromeEmulatedMedia,
    fetchFailIgnore: options.fetchFailIgnore,
    chromeEnableAnimations: options.chromeEnableAnimations // this line
  },
  configuration,
  parameters.loki || {}
);

Steps to Reproduce

  1. Attempt to pass the chromeEnableAnimations flag to Loki.
  2. Observe that animations are not enabled.

Context (Environment)

  • Loki Version: 0.35.0
  • Node Version: 18.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant