From cdb5f830f19345df1fa59497a85466abd818261b Mon Sep 17 00:00:00 2001 From: h1alexbel Date: Thu, 21 Nov 2024 14:09:12 +0300 Subject: [PATCH 1/4] fix(#28): warn about abstract-decoratee --- .../resources/org/eolang/lints/errors/abstract-decoratee.xsl | 4 ++-- .../org/eolang/lints/catches-abstract-decoratee.yaml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/resources/org/eolang/lints/errors/abstract-decoratee.xsl b/src/main/resources/org/eolang/lints/errors/abstract-decoratee.xsl index ca14d7b..681ac85 100644 --- a/src/main/resources/org/eolang/lints/errors/abstract-decoratee.xsl +++ b/src/main/resources/org/eolang/lints/errors/abstract-decoratee.xsl @@ -33,9 +33,9 @@ SOFTWARE. - error + warning - Abstract object can't be used as a decoratee + Abstract object shouldn't be used as a decoratee diff --git a/src/test/resources/org/eolang/lints/catches-abstract-decoratee.yaml b/src/test/resources/org/eolang/lints/catches-abstract-decoratee.yaml index afcc9ef..5a869c5 100644 --- a/src/test/resources/org/eolang/lints/catches-abstract-decoratee.yaml +++ b/src/test/resources/org/eolang/lints/catches-abstract-decoratee.yaml @@ -23,7 +23,7 @@ xsls: - /org/eolang/lints/errors/abstract-decoratee.xsl tests: - - /defects[count(defect[@severity='error'])=1] + - /defects[count(defect[@severity='warning'])=1] - /defects/defect[@line='4'] eo: | # This is the default 64+ symbols comment in front of abstract object. From 243085a1fa73bdba508dd8712f5e86d555048ba7 Mon Sep 17 00:00:00 2001 From: h1alexbel Date: Thu, 21 Nov 2024 14:15:04 +0300 Subject: [PATCH 2/4] fix(#28): move to comments --- .../eolang/lints/{errors => comments}/abstract-decoratee.xsl | 0 .../resources/org/eolang/lints/catches-abstract-decoratee.yaml | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename src/main/resources/org/eolang/lints/{errors => comments}/abstract-decoratee.xsl (100%) diff --git a/src/main/resources/org/eolang/lints/errors/abstract-decoratee.xsl b/src/main/resources/org/eolang/lints/comments/abstract-decoratee.xsl similarity index 100% rename from src/main/resources/org/eolang/lints/errors/abstract-decoratee.xsl rename to src/main/resources/org/eolang/lints/comments/abstract-decoratee.xsl diff --git a/src/test/resources/org/eolang/lints/catches-abstract-decoratee.yaml b/src/test/resources/org/eolang/lints/catches-abstract-decoratee.yaml index 5a869c5..6a44496 100644 --- a/src/test/resources/org/eolang/lints/catches-abstract-decoratee.yaml +++ b/src/test/resources/org/eolang/lints/catches-abstract-decoratee.yaml @@ -21,7 +21,7 @@ # SOFTWARE. --- xsls: - - /org/eolang/lints/errors/abstract-decoratee.xsl + - /org/eolang/lints/comments/abstract-decoratee.xsl tests: - /defects[count(defect[@severity='warning'])=1] - /defects/defect[@line='4'] From 01485f9088a60ab4ec1a83b5118c1767f53e7a94 Mon Sep 17 00:00:00 2001 From: h1alexbel Date: Thu, 21 Nov 2024 14:16:29 +0300 Subject: [PATCH 3/4] chore: trailing off --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e8e1adc..6477311 100644 --- a/README.md +++ b/README.md @@ -16,7 +16,7 @@ This Java package is a collection of "lints" (aka "checkers") for formatting. This is about best practices and readiness of code for successful compilation and execution. -We use this package as a dependency in the +We use this package as a dependency in the [EO-to-Java compiler][eo]: ```xml From a4d3844c3076ab5081682c18f2d4b0680e0ec1a2 Mon Sep 17 00:00:00 2001 From: h1alexbel Date: Thu, 21 Nov 2024 14:23:53 +0300 Subject: [PATCH 4/4] fix(#28): actually its an error --- .../eolang/lints/{comments => errors}/abstract-decoratee.xsl | 0 .../resources/org/eolang/lints/catches-abstract-decoratee.yaml | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename src/main/resources/org/eolang/lints/{comments => errors}/abstract-decoratee.xsl (100%) diff --git a/src/main/resources/org/eolang/lints/comments/abstract-decoratee.xsl b/src/main/resources/org/eolang/lints/errors/abstract-decoratee.xsl similarity index 100% rename from src/main/resources/org/eolang/lints/comments/abstract-decoratee.xsl rename to src/main/resources/org/eolang/lints/errors/abstract-decoratee.xsl diff --git a/src/test/resources/org/eolang/lints/catches-abstract-decoratee.yaml b/src/test/resources/org/eolang/lints/catches-abstract-decoratee.yaml index 6a44496..5a869c5 100644 --- a/src/test/resources/org/eolang/lints/catches-abstract-decoratee.yaml +++ b/src/test/resources/org/eolang/lints/catches-abstract-decoratee.yaml @@ -21,7 +21,7 @@ # SOFTWARE. --- xsls: - - /org/eolang/lints/comments/abstract-decoratee.xsl + - /org/eolang/lints/errors/abstract-decoratee.xsl tests: - /defects[count(defect[@severity='warning'])=1] - /defects/defect[@line='4']