Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect-test-object-name is too restrictive #267

Open
yegor256 opened this issue Jan 22, 2025 · 2 comments
Open

incorrect-test-object-name is too restrictive #267

yegor256 opened this issue Jan 22, 2025 · 2 comments
Assignees
@h1alexbel
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@yegor256
Copy link
Member

I'm getting this:

The name of the object "throws-on-converting-to-i32-if-out-of-bounds" 
doesn't match "^[a-z][a-z]+(-[a-z][a-z]+)*$" (incorrect-test-object-name)

It's too restrictive. Let's allow numbers there too, not only letters.
@yegor256 yegor256 added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jan 22, 2025
@h1alexbel
Copy link
Contributor

@yegor256 I will take this

h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 22, 2025
@h1alexbel
bug(objectionary#267): allow numbers
4f19f06
@h1alexbel h1alexbel mentioned this issue Jan 22, 2025
Merged
yegor256 added a commit that referenced this issue Jan 22, 2025
@yegor256
Merge pull request #269 from h1alexbel/267
273faf7 
bug(#267): `incorrect-test-object-name` allows numbers
@Jeremy-Suon
Copy link

^[a-z0-9][a-z0-9]+(-[a-z0-9][a-z0-9]+)*$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h1alexbel h1alexbel

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yegor256 @h1alexbel @Jeremy-Suon