Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for querying function parameters in the schema #154

Closed
obi1kenobi opened this issue Oct 17, 2022 · 1 comment
Closed

Initial support for querying function parameters in the schema #154

obi1kenobi opened this issue Oct 17, 2022 · 1 comment
Labels
C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

Make an MVP for accessing function parameters in the schema. Aim to make it possible to write lints that detect changes in the number of parameters a function takes.

Parameter names can be changed without violating semver so are not critical to support, but are a "nice-to-have" for e.g. the Playground. Add them to the schema if possible.

Parameter type information is a bit more difficult to represent due to #149, so feel free to ignore types for now in the interest of moving quickly.

Relevant portion of the schema:
https://github.com/obi1kenobi/trustfall-rustdoc-adapter/blob/main/src/rustdoc_schema.graphql#L430-L493

@obi1kenobi obi1kenobi added C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Oct 17, 2022
@tonowak
Copy link
Collaborator

tonowak commented Nov 15, 2022

Implemented in #170. Should I close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Development

No branches or pull requests

2 participants