Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language on x5c protection #240

Open
awoie opened this issue Jul 8, 2024 · 1 comment
Open

Add language on x5c protection #240

awoie opened this issue Jul 8, 2024 · 1 comment
Labels
discuss Discuss

Comments

@awoie
Copy link
Collaborator

awoie commented Jul 8, 2024

To mitigate attacks described in the X.509 IETF RFC here, we should add something like the following language:

If x5c is the in unprotected header or was received out-of-band, the verifier MUST check the x5t protected header.

Note that COSE has this language built in, but JOSE leaves that open.

@bc-pi
Copy link
Collaborator

bc-pi commented Jul 8, 2024

Noting that the current text requires using x5c and says nothing about protected vs. unprotected

https://www.ietf.org/archive/id/draft-ietf-oauth-sd-jwt-vc-04.html#name-issuer-signed-jwt-verificat

@awoie awoie added the discuss Discuss label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Discuss
Projects
None yet
Development

No branches or pull requests

2 participants