Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send decimal value if is wrong format #402

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

taopkorczak
Copy link
Contributor

Related to: https://oat-sa.atlassian.net/browse/TR-6116

After implementing decimal validation, in cases of incorrect format, no value was sent. The 'invalid' class on the input prevented data from being taken from the input, which caused the errors. Removing the 'invalid' class and leaving the 'error' class for correct CSS styling was the solution for this bug.

Nagranie.z.ekranu.2024-06-11.o.08.59.40.mov

Copy link

Version

Target Version 2.3.1
Last version 2.3.0

There are 0 BREAKING CHANGE, 0 feature, 1 fix

Copy link

Coverage Report

Totals Coverage
Statements: 67.43% ( 9159 / 13583 )
Methods: 69.48% ( 1054 / 1517 )
Lines: 71.93% ( 5437 / 7559 )
Branches: 59.2% ( 2668 / 4507 )

StandWithUkraine

Copy link
Contributor

@olga-kulish olga-kulish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as requested, though I think that correct would be to send no response if value is invalid, as you had before.
[Or more like, I think all responses must be string, so reviewer simply sees exactly what user had enetered.]

@wazelin wazelin merged commit 72b5095 into develop Jun 11, 2024
1 of 2 checks passed
@wazelin wazelin deleted the fix/TR-6116/decimal-value branch June 11, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants