feat!: update dependenies to use lodash v4 #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
yukipastelcat
requested changes
Oct 13, 2023
src/qtiCommonRenderer/renderers/interactions/AssociateInteraction.js
Outdated
Show resolved
Hide resolved
src/qtiCommonRenderer/renderers/interactions/GraphicAssociateInteraction.js
Outdated
Show resolved
Hide resolved
taopkorczak
reviewed
Oct 13, 2023
Co-authored-by: Kirill Sedunov <[email protected]> Signed-off-by: shaveko <[email protected]>
…ion.js Co-authored-by: Kirill Sedunov <[email protected]> Signed-off-by: shaveko <[email protected]>
…nteraction.js Co-authored-by: Kirill Sedunov <[email protected]> Signed-off-by: shaveko <[email protected]>
Co-authored-by: Kirill Sedunov <[email protected]> Signed-off-by: shaveko <[email protected]>
Co-authored-by: Kirill Sedunov <[email protected]> Signed-off-by: shaveko <[email protected]>
Co-authored-by: Kirill Sedunov <[email protected]> Signed-off-by: shaveko <[email protected]>
Co-authored-by: Kirill Sedunov <[email protected]> Signed-off-by: shaveko <[email protected]>
|
@yukipastelcat @taopkorczak Thanks for your review. @yukipastelcat please check my comments on some of your questions and suggestions |
jsconan
reviewed
Oct 17, 2023
There was a problem hiding this comment.
Tests pass. However, please also take care of the deprecated API: _.each() is replaced by _.forEach().
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
yukipastelcat
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Code is looking good, tests are passing, good job👍
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not master
taopkorczak
approved these changes
Oct 17, 2023
Version🚨 Your pull request contains a BREAKING CHANGE, please be sure to communicate it.
There are 1 BREAKING CHANGE, 1 feature, 16 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://oat-sa.atlassian.net/browse/ADF-1595
Description
Update of depnendencies to use lodash 4
Update code to be compatible with lodash v4 api
How to test
npm run test