chore: update methods to lodash 4 verios #496
Conversation
There was a problem hiding this comment.
Please ensure that you are following correct upgrade guide.
https://github.com/lodash/lodash/wiki/Migrating is about moving from underscore library to lodash library, it's not our case.
But we need https://github.com/lodash/lodash/wiki/Changelog (see also https://github.com/lodash/lodash/wiki/Deprecations)
Yes, many updates are similar, but not all.
For example, there's no need to change from each to forEach, because they are the same function in lodash: https://lodash.com/docs/4.17.15#forEach (each is an alias for forEach)
I don't mind this change, just let's ensure we didn't miss other changes we actually needed to do.
Notice an interesting comment in Kyril's PR: oat-sa/tao-core-ui-fe#568 (comment)
"Why did you change it from remove to pull?"
"Lodash changed _.remove implementation a bit - predicate is now a function, and to remove elements from array by value - it's recommended to use _.pull"
For example, here https://github.com/oat-sa/extension-tao-itemqti/blob/feature/ADF-1579/update-lodash-to-4/views/js/qtiCreator/widgets/interactions/helpers/pairScoringForm.js#L143
the same thing is used.
I didn't notice anything about this in the changelog, so maybe it's actually backwards-compatible and no change is needed? If not, maybe it's more reliable to not only follow the changelog, but also to compare the documentation:
New docs: https://lodash.com/docs/4.17.15.
Old docs: https://lodash.com/docs/2.4.2
Create a list of lodash functions used in these repositories, and compare docs for them.
…ash v4 Signed-off-by: Sergei Mikhailov <[email protected]>
Version
There are 0 BREAKING CHANGE, 0 feature, 0 fix |
Front-end summary Node 18
|
Related: https://oat-sa.atlassian.net/browse/ADF-1579
Update lodash methods to version 4.
Documentation: https://github.com/lodash/lodash/wiki/Migrating