Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pci: Should update ISR related description about MSI-X #145

Open
zkq opened this issue Sep 2, 2022 · 4 comments
Open

pci: Should update ISR related description about MSI-X #145

zkq opened this issue Sep 2, 2022 · 4 comments

Comments

@zkq
Copy link

zkq commented Sep 2, 2022

In commit 6a83c1d ("pci: set ISR bit on config change with MSI-X"),
device is required to set ISR bit on config change even when MSI-X enabled.

We should update other ISR related description for above commit. Here I have
a RFC change:
https://lists.oasis-open.org/archives/virtio-comment/202209/msg00001.html

And the latest change is v2:
https://lists.oasis-open.org/archives/virtio-comment/202209/msg00024.html

Thanks,
Keqian

@cohuck
Copy link
Contributor

cohuck commented Sep 2, 2022

Thank you for your contribution.

Please follow the process outlined in https://github.com/oasis-tcs/virtio-spec#providing-feedback; in particular, all proposed changes must be posted to the mailing list.

Feel free to re-use this issue for requesting a vote later on (but please edit the description if you do so.)

@zkq
Copy link
Author

zkq commented Sep 2, 2022

Thx, I have sent a patch: https://lists.oasis-open.org/archives/virtio-comment/202209/msg00001.html

And I have a question. What do you mean "requesting a vote"? Thanks.

@cohuck
Copy link
Contributor

cohuck commented Sep 2, 2022

See https://github.com/oasis-tcs/virtio-spec#use-of-github-issues -- basically, if you managed to get consensus for your proposed change, you need to request that the TC votes on it before it can be integrated.

@zkq
Copy link
Author

zkq commented Sep 4, 2022

See https://github.com/oasis-tcs/virtio-spec#use-of-github-issues -- basically, if you managed to get consensus for your proposed change, you need to request that the TC votes on it before it can be integrated.

Got it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants