From eca28ae3a6a6e56ed0782c930d00c05e32484651 Mon Sep 17 00:00:00 2001 From: AMZN-Gene Date: Tue, 24 Sep 2024 16:34:54 -0700 Subject: [PATCH] Adding comment as to why compile with warnings not treated as error. Assimp's USD support requires compiling TinyUSDZ, which contains compile warnings Signed-off-by: AMZN-Gene --- package-system/assimp/build_assimp_windows.cmd | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/package-system/assimp/build_assimp_windows.cmd b/package-system/assimp/build_assimp_windows.cmd index 84777d89..fd451f93 100644 --- a/package-system/assimp/build_assimp_windows.cmd +++ b/package-system/assimp/build_assimp_windows.cmd @@ -12,6 +12,7 @@ @rem # cmake expects fowardslashes: set "DOWNLOADED_PACKAGE_FOLDERS=%DOWNLOADED_PACKAGE_FOLDERS:\=/%" +@rem # /w compiler option. Assimp USD is implemented using TinyUSDZ which, unfortunately, contains compiler warnings cmake -S temp/src ^ -DBUILD_SHARED_LIBS=OFF ^ -DCMAKE_BUILD_TYPE=Release ^ @@ -19,11 +20,12 @@ cmake -S temp/src ^ -DASSIMP_BUILD_ZLIB=OFF ^ -DASSIMP_BUILD_ASSIMP_TOOLS=ON ^ -DASSIMP_BUILD_USD_IMPORTER=ON ^ - -DCMAKE_CXX_FLAGS="/EHsc /wd4777 /wd5032" ^ + -DCMAKE_CXX_FLAGS="/EHsc /w" ^ temp/src/CMakeLists.txt || exit /b 1 cmake --build temp/src --config release || exit /b 1 cmake --build temp/src --config debug || exit /b 1 +@rem # /w compiler option. Assimp USD is implemented using TinyUSDZ which, unfortunately, contains compiler warnings cmake -S temp/src ^ -DBUILD_SHARED_LIBS=ON ^ -DCMAKE_BUILD_TYPE=Release ^ @@ -31,7 +33,7 @@ cmake -S temp/src ^ -DASSIMP_BUILD_ZLIB=OFF ^ -DASSIMP_BUILD_ASSIMP_TOOLS=ON ^ -DASSIMP_BUILD_USD_IMPORTER=ON ^ - -DCMAKE_CXX_FLAGS="/EHsc /wd4777 /wd5032" ^ + -DCMAKE_CXX_FLAGS="/EHsc /w" ^ temp/src/CMakeLists.txt || exit /b 1 cmake --build temp/src --config release || exit /b 1 cmake --build temp/src --config debug || exit /b 1