diff --git a/2024-01-31_OpenTelemetry_Looks_Good_To_Me/README.md b/2024-01-31_OpenTelemetry_Looks_Good_To_Me/README.md
index 2acf556b..edf96629 100644
--- a/2024-01-31_OpenTelemetry_Looks_Good_To_Me/README.md
+++ b/2024-01-31_OpenTelemetry_Looks_Good_To_Me/README.md
@@ -10,6 +10,10 @@ LGTM are a GrafanaLabs products initials and a joke for Loki, Grafana, Tempo and
+## Introduction
+Reference: https://o11y-weekly.github.io/2023-11-30_What_is_OpenTelemetry/
+A [previous post](https://o11y-weekly.github.io/2023-11-30_What_is_OpenTelemetry/) is available to explain what is OpenTelemetry while this post is focusing on how to use it and what is the outcome ?
+
## Naming conventions / Semantic-conventions
References:
- https://opentelemetry.io/docs/concepts/semantic-conventions/
diff --git a/2024-01-31_OpenTelemetry_Looks_Good_To_Me/demo/compose.yml b/2024-01-31_OpenTelemetry_Looks_Good_To_Me/demo/compose.yml
index 57abd711..ed71a574 100644
--- a/2024-01-31_OpenTelemetry_Looks_Good_To_Me/demo/compose.yml
+++ b/2024-01-31_OpenTelemetry_Looks_Good_To_Me/demo/compose.yml
@@ -65,7 +65,8 @@ services:
- SERVICE_NAME=service
- SERVICE_NAMESPACE=demo
- DEPLOYMENT_ENVIRONMENT=dev
- - FAILURE_RATIO=0.0001
+ - FAILURE_RATIO=0.1 # demo parameter
+ - LATENCY_RATIO=1 # demo parameter
- MIN_LATENCY=0 #ms
- MAX_LATENCY=100 #ms
- OTEL_TRACES_SAMPLER=parentbased_always_on
@@ -96,7 +97,7 @@ services:
- SERVICE_NAMESPACE=demo
- DEPLOYMENT_ENVIRONMENT=dev
- OTEL_TRACES_SAMPLER=parentbased_traceidratio
- - OTEL_TRACES_SAMPLER_ARG=1
+ - OTEL_TRACES_SAMPLER_ARG=0.1 # demo parameter
- OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf
- OTEL_EXPORTER_OTLP_ENDPOINT=http://otelcontribcol-gateway:4318
- OTEL_METRICS_EXPORTER=none
diff --git a/2024-01-31_OpenTelemetry_Looks_Good_To_Me/demo/otelcontribcol/gateway/pipeline.traces.yml b/2024-01-31_OpenTelemetry_Looks_Good_To_Me/demo/otelcontribcol/gateway/pipeline.traces.yml
index 4ac9779c..5fbe3a72 100644
--- a/2024-01-31_OpenTelemetry_Looks_Good_To_Me/demo/otelcontribcol/gateway/pipeline.traces.yml
+++ b/2024-01-31_OpenTelemetry_Looks_Good_To_Me/demo/otelcontribcol/gateway/pipeline.traces.yml
@@ -3,7 +3,7 @@ exporters:
endpoint: otelcontribcol-traces-loadbalancer:4317
tls:
insecure: true
- otlp/traces:
+ otlp/traces-collector:
endpoint: otelcontribcol-traces-collector:4317
tls:
insecure: true
@@ -18,8 +18,9 @@ service:
traces/gateway:
receivers: [otlp/gateway]
processors: [batch/traces-loadbalancer]
+ # demo parameter
# choose one of :
# - otlp/traces-loadbalancer: forward to a loadbalancer collector over multiple tail sampling collectors
- # - otlp/traces : forward to tail sampling collector
+ # - otlp/traces-collector : forward to tail sampling collector
# - otlphttp/tempo: send traces to tempo directly without tail-sampling
exporters: [otlp/traces-loadbalancer, debug]
\ No newline at end of file
diff --git a/2024-01-31_OpenTelemetry_Looks_Good_To_Me/slides/index.html b/2024-01-31_OpenTelemetry_Looks_Good_To_Me/slides/index.html
index 770a4b6b..6a9980d5 100644
--- a/2024-01-31_OpenTelemetry_Looks_Good_To_Me/slides/index.html
+++ b/2024-01-31_OpenTelemetry_Looks_Good_To_Me/slides/index.html
@@ -18,6 +18,16 @@
![Looks Good To Me](./lgtm.png)
+