-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TOTALLY BREAKING CHANGE: Rewrite of Nyx to rely on ANISE for planetary data and frame transformations #305
TOTALLY BREAKING CHANGE: Rewrite of Nyx to rely on ANISE for planetary data and frame transformations #305
Conversation
This reverts commit 4575ae1.
…rking on these now)
…Cosm and JPL. Cosm GM was 398600.435392. NASA JPL (in PCK11.pca) is 398600.435436096 Down to 24 failures
This ensures that the gravity models match. As expected, ANISE increases the accuracy.
Visit the preview URL for this PR (updated for commit 9b7e3b9): https://nyx-rustdoc--pr305-86-use-spice-files-v-wags5d8k.web.app (expires Sun, 23 Jun 2024 04:03:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d8e2a55934352d850c15d11866c39eb2d2e029be |
@gwbres, I'm getting there! It only took four months on this branch and 2-3 years on ANISE?
|
hang in there ! I'm sorry i can't help much on the nyx topic :) i'm glad some of my applications may serve as beta tester though. If that can comfort, I'm also breaking a few low level things in my crate, these phases are annoying, I'd personnaly would be working on more interesting sides of the applications, but sometimes what needs to be done, has to be done. If you're interested, i'm reorganizing some key elements that are still coded in the RINEX lib, while it should not. |
Effects
This is a complete rewrite of the whole
Cosm
functionality that's been used in Nyx since its inception. Nyx now uses ANISE, which relies on NAIF BSP and BPC files for transformations and rotations and "ANISE files" for planetary data.This big breaking change will be followed by tutorials and user guides for writing mission design and orbit determination scenarios using Nyx.
Known limitations
This update leads to a significant decrease in computational performance as documented in ANISEDataset
performance issues anise#248 , but I'm already working on the fix.Errors must be boxed: Add boxed_context and with_boxed_context shepmaster/snafu#455 (comment)