Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize youtube embeds to support more content #220

Open
voshawn opened this issue Sep 16, 2020 · 1 comment
Open

Generalize youtube embeds to support more content #220

voshawn opened this issue Sep 16, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers to the project that are familiar with the tech Library uses good for learning Issues well scoped for those learning Node/other project tech needs more context Needs more info or to be broken into multiple issues before actionable

Comments

@voshawn
Copy link

voshawn commented Sep 16, 2020

Problem Description

From this #67, it seems like we can embed youtube videos. I would like to be able to embed other content as well. For example, we would like to embed:

  1. Google Drive Videos
  2. Google slides / sheets
  3. Other platforms (for example, our company uses cloudapp for internal video sharing)

Feature

Could we have config settings that allow users to set domains / URL patterns? This way we can decide what type of links we want to parse and how they would be embedded.

We might want to have some embed syntax to avoid automatically embedding everything.

I could try to take a stab at this feature if this is something you think Library should support. It seems like since we already support youtube it would be in scope?

@voshawn voshawn added the enhancement New feature or request label Sep 16, 2020
@afischer afischer added good first issue Good for newcomers to the project that are familiar with the tech Library uses good for learning Issues well scoped for those learning Node/other project tech needs more context Needs more info or to be broken into multiple issues before actionable labels May 25, 2021
@afischer
Copy link
Member

Hey @voshawn, thanks for the issue and sorry for the late reply!

I think this could be a great addition for some specific platforms (youtube, vimeo, maybe google slides, some others!), but we should probably decide on some syntax for embeds vs links as right now, youtube video URLs are automatically turned into embeds, which might be unexpected behavior for some users. Perhaps surrounding a link by double brackets (e.g. [[https://yotutube.com/embedme]] would be an easy way to denote embeddable content.

This might also be a good candidate for a plugin when #249 is complete.

In the mean time, we have an advanced feature that allows for custom code to be inserted directly in the document if desired. If you enable ALLOW_INLINE_CODE, you could insert arbitrary HTML into your google doc. (Note that the example on that linked demo page does not render as the inline code feature is turned off on the public site for security reasons.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers to the project that are familiar with the tech Library uses good for learning Issues well scoped for those learning Node/other project tech needs more context Needs more info or to be broken into multiple issues before actionable
Projects
None yet
Development

No branches or pull requests

2 participants