Add FlowSession.modified_on
#5816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ified sessions but only if they haven't been modified since the task was queued.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5816 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 455 456 +1
Lines 25078 25083 +5
=========================================
+ Hits 25078 25083 +5 ☔ View full report in Codecov by Sentry. |
norkans7
approved these changes
Jan 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To act as check for queued tasks that modify sessions but only if they haven't been modified since the task was queued.
We currently do this for wait timeouts by checking queuing the task with the wait timeout value and checking that against the db value, and we currently do this for expirations using the expiration value... but there's no similar check for sessions that are exited because they've expired but aren't resumable.