From cec1bca02453f10c2e69d96b94a040386877d16e Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Mon, 18 Sep 2023 22:35:43 -0400 Subject: [PATCH 01/10] build(npm): update to v10.1.0 --- package.json | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/package.json b/package.json index 1836dc6..e98dcb7 100644 --- a/package.json +++ b/package.json @@ -36,10 +36,7 @@ "devDependencies": { "request": "^2.53.0" }, - "engines": { - "node": "v20.5.0" - }, - "packageManager": "npm@9.8.1", + "packageManager": "npm@10.1.0", "keywords": [ "nw", "nw.js", From e8cbd1c4604f4ae691a2b7202b5c59583413b2b0 Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Mon, 18 Sep 2023 22:36:06 -0400 Subject: [PATCH 02/10] build(dependabot): batch updates --- .github/dependabot.yml | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 31941f4..07aedba 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -1,10 +1,20 @@ version: 2 updates: - package-ecosystem: "npm" - directory: "/" + directory: "." schedule: - interval: "daily" + interval: "weekly" + day: "saturday" + groups: + npm: + patterns: + - "*" - package-ecosystem: "github-actions" directory: ".github/" schedule: - interval: "daily" + interval: "weekly" + day: "saturday" + groups: + gha: + patterns: + - "*" From d8bc4682ce7cb9920a60ce7858c75e13dc3f4b4f Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Mon, 18 Sep 2023 22:36:27 -0400 Subject: [PATCH 03/10] ci: use latest Node version --- .github/workflows/ci.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index da2f660..c85243a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,12 +9,10 @@ jobs: runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3.3.0 - - name: Get Node version from Node manifest - run: | - echo "NODE_VER=$(jq -r '.engines.node' package.json | sed 's/v//' )" >> $GITHUB_ENV - - uses: actions/setup-node@v3.6.0 + - name: Setup Node + uses: actions/setup-node@v3.6.0 with: - node-version: ${{ env.NODE_VER }} + node-version: "latest" cache: "npm" - name: Enable corepack run: corepack enable From c63e6fa92a50b83684460916a3c2f33ae2a1bd65 Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Mon, 18 Sep 2023 22:41:44 -0400 Subject: [PATCH 04/10] chore: revert some changes --- .github/dependabot.yml | 2 +- .github/workflows/ci.yml | 9 +++++++-- package.json | 3 +++ 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 07aedba..6489526 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -10,7 +10,7 @@ updates: patterns: - "*" - package-ecosystem: "github-actions" - directory: ".github/" + directory: ".github/workflows" schedule: interval: "weekly" day: "saturday" diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c85243a..b400251 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,11 +8,16 @@ jobs: test: runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v3.3.0 + - name: Get Node version from Node manifest + run: | + echo "NODE_VER=$(jq -r '.engines.node' package.json | sed 's/v//' )" >> $GITHUB_ENV + - uses: actions/setup-node@v3.6.0 + - name: Checkout repository + uses: actions/checkout@v3.3.0 - name: Setup Node uses: actions/setup-node@v3.6.0 with: - node-version: "latest" + node-version: ${{ env.NODE_VER }} cache: "npm" - name: Enable corepack run: corepack enable diff --git a/package.json b/package.json index e98dcb7..b63e43f 100644 --- a/package.json +++ b/package.json @@ -36,6 +36,9 @@ "devDependencies": { "request": "^2.53.0" }, + "engines": { + "node": "v20.5.0" + }, "packageManager": "npm@10.1.0", "keywords": [ "nw", From 63022481da78de01feae7f08f9c23cd0b8c2d88a Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Mon, 18 Sep 2023 22:43:26 -0400 Subject: [PATCH 05/10] fix: do not pin node version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index b63e43f..d814507 100644 --- a/package.json +++ b/package.json @@ -37,7 +37,7 @@ "request": "^2.53.0" }, "engines": { - "node": "v20.5.0" + "node": ">= 20.5.0" }, "packageManager": "npm@10.1.0", "keywords": [ From 6f2bb92f38852d81f3b0629d4c6463048aa967a0 Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Mon, 18 Sep 2023 22:44:41 -0400 Subject: [PATCH 06/10] chore: revert batch update --- .github/dependabot.yml | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 6489526..06f9a85 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -1,20 +1,10 @@ version: 2 updates: - package-ecosystem: "npm" - directory: "." + directory: "/" schedule: - interval: "weekly" - day: "saturday" - groups: - npm: - patterns: - - "*" + interval: "daily" - package-ecosystem: "github-actions" directory: ".github/workflows" schedule: - interval: "weekly" - day: "saturday" - groups: - gha: - patterns: - - "*" + interval: "daily" From c9ddc234eceb59932b6233d6354de4c744c0ce83 Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Mon, 18 Sep 2023 22:47:17 -0400 Subject: [PATCH 07/10] build(node): allow LTS --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index d814507..1a13ecb 100644 --- a/package.json +++ b/package.json @@ -37,7 +37,7 @@ "request": "^2.53.0" }, "engines": { - "node": ">= 20.5.0" + "node": ">= 20.5.0 || >= 18.18.0" }, "packageManager": "npm@10.1.0", "keywords": [ From 3a47e9d15aa141b5870dcf3a676989479c0150bb Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Mon, 18 Sep 2023 22:50:42 -0400 Subject: [PATCH 08/10] fix(ci): checkout repo before parsing Node version --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b400251..2e3e479 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,12 +8,12 @@ jobs: test: runs-on: ubuntu-22.04 steps: + - name: Checkout repository + uses: actions/checkout@v3.3.0 - name: Get Node version from Node manifest run: | echo "NODE_VER=$(jq -r '.engines.node' package.json | sed 's/v//' )" >> $GITHUB_ENV - uses: actions/setup-node@v3.6.0 - - name: Checkout repository - uses: actions/checkout@v3.3.0 - name: Setup Node uses: actions/setup-node@v3.6.0 with: From 11b6aea9747966f37503f77ef76397ce0372ae64 Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Mon, 18 Sep 2023 22:56:10 -0400 Subject: [PATCH 09/10] fix(ci: remove duplicate setup node step --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2e3e479..e45a03d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,6 @@ jobs: - name: Get Node version from Node manifest run: | echo "NODE_VER=$(jq -r '.engines.node' package.json | sed 's/v//' )" >> $GITHUB_ENV - - uses: actions/setup-node@v3.6.0 - name: Setup Node uses: actions/setup-node@v3.6.0 with: From 27c42be3bf05e4c9cc62a2302c039549fb97542c Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Tue, 19 Sep 2023 14:49:33 -0400 Subject: [PATCH 10/10] fix(ci): get Node version from manifest --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e45a03d..b28b1b6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,8 +11,7 @@ jobs: - name: Checkout repository uses: actions/checkout@v3.3.0 - name: Get Node version from Node manifest - run: | - echo "NODE_VER=$(jq -r '.engines.node' package.json | sed 's/v//' )" >> $GITHUB_ENV + run: echo "NODE_VER=$(curl -s https://nwjs.io/versions | jq -r ".versions[0].components.node")" >> $GITHUB_ENV - name: Setup Node uses: actions/setup-node@v3.6.0 with: