Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S4 Pull in final version of SPS data #27

Open
Tracked by #35
eeholmes opened this issue Apr 16, 2022 · 0 comments
Open
Tracked by #35

S4 Pull in final version of SPS data #27

eeholmes opened this issue Apr 16, 2022 · 0 comments
Assignees
Labels
Milestone

Comments

@eeholmes
Copy link
Member

Items to fix

  • Line 6312-6515 is all blank for spawners, fracwild and catch. Probably good to put -99 there to make clear that these are years with missing data not a mistake.

  • Same with lines 5778-5792

  • The FRACWILD column still has some blanks (besides those above). That has tripped us up in the past since these are interpreted as -99. Might be good to make them -99 to be clear that they are.

  • The ESU column has 3 ESUs that don't follow the format of all the others: Hood Canal, Ozette Lake Sockeye Salmon ESU, Puget Sound. All the other ESUs look something like "Steelhead (Puget Sound DPS)"

  • The RUN_TIMING column has a variety of formats. e.g. Su, Summer, and SumR. Wi, Winter and WR.

  • NUMBER_OF_SPAWNERS column has blanks. Those should be -99 to be clear that they are missing.

  • SPECIES has both Chinook and Chinook salmon

  • Are we using BROOD_YEAR as the year column? I thought we switched to YEAR.

  • Are we using START and END columns? Mostly they are blank. If we are, note that some of the END values are different, e.g. 1968-2019 instead of 2019.

@eeholmes eeholmes added this to the 2020.3 milestone Apr 16, 2022
@eeholmes eeholmes changed the title Pull in final version of SPS data S3 Pull in final version of SPS data Apr 22, 2022
@eeholmes eeholmes added the Story label Apr 22, 2022
@eeholmes eeholmes mentioned this issue Jun 3, 2022
1 task
@eeholmes eeholmes changed the title S3 Pull in final version of SPS data S4 Pull in final version of SPS data Jun 3, 2022
@eeholmes eeholmes moved this to Todo in Kanban-beta Jun 3, 2022
@eeholmes eeholmes self-assigned this Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant