Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved npm dependencies to devDependencies #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ProLoser
Copy link

Not sure how knowledgable you are on npm design patterns.

I installed this package using npm install nwcell/ics.js but it came with a lot of stuff I don't need in production. Obviously I don't need grunt or bower or the libraries you hard-coded into the distribution files in order to consume your library. I only need those dependencies if I want to develop your package itself. Therefore I've moved those dependencies down.

If you want to be consumed by node but not hard-code the third party packages, I would keep file-saver as a production dependency and use something like rollup or browserify or something to distribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants