Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Support generatesMetadataFilesAtProjectRoot #53

Open
1 task done
jvalkeal opened this issue Dec 20, 2023 · 3 comments
Open
1 task done

feature: Support generatesMetadataFilesAtProjectRoot #53

jvalkeal opened this issue Dec 20, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jvalkeal
Copy link

Did you check the docs?

  • I have read all the docs

Is your feature request related to a problem? Please describe.

Project metadata should not be generated inside a project.

redhat-developer/vscode-java#618
https://devblogs.microsoft.com/java/say-goodbye-to-project-files-in-1-1-0/

Describe the solution you'd like

jdtls has an option which can be passed by using -Djava.import.generatesMetadataFilesAtProjectRoot=false. This is the default i.e. vscode uses thought they provide an option so that user can change it.

Describe alternatives you've considered

Think there's none unless you somehow try to override whole command launching jdtls.

Additional context

No response

@jvalkeal jvalkeal added the enhancement New feature or request label Dec 20, 2023
@s1n7ax
Copy link
Member

s1n7ax commented Dec 20, 2023

@jvalkeal I will do a research and make it default. Changing cmd arguments are not possible. Do you think taking cmd arguments through require 'java'.setup() should be implemented? or allow functions in the setup configuration and let the user handle them if a function is passed?

@s1n7ax s1n7ax self-assigned this Dec 20, 2023
@s1n7ax s1n7ax added this to the v2.0.0 milestone Dec 20, 2023
@jvalkeal
Copy link
Author

I don't think user should ever have full control of the command. One other thing which is absolutely something user need to controls is:

Default memory setting is fine for simple projects but will need to be changed with larger projects. ldtls in vscode quite often crashes and then it will propose to change memory settings. It'd be nice to have a generic way to modify some settings from a main config.

@jvalkeal
Copy link
Author

I was looking to just PR this little change but realised that obviously it needs to go in with #54. Once metadata moves out from a project directory into a shared workspace directory, that workspace needs to be unique as .metadata dir will get mixed up.

@s1n7ax s1n7ax assigned jvalkeal and unassigned s1n7ax Dec 22, 2023
@s1n7ax s1n7ax moved this to In Progress in Java for Neovim Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants