Fix Kafka offset checking test #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
added
bug
This reverts commit 15a7365.
… the source's yield returns. Adjust the offset checker to pass if there is a new partition introduced.
…prior to the source's yield returns." This reverts commit 948f4ef.
… after the pipeline completes. The reason is that the C++ impl commits the offsets after calling on_next, this also adds the ability to check async commits as well
dagardner-nv
changed the title
dagardner-nv
removed
the
DO NOT MERGE
mdemoret-nv
approved these changes
Sep 22, 2023
|
/merge |
dagardner-nv
added a commit
to dagardner-nv/Morpheus
that referenced
this pull request
Oct 4, 2023
* Fixes intermittent failures in `tests/test_kafka_source_stage_pipe.py::test_kafka_source_commit` * The test checked the offsets in a stage, however the C++ impl for the source stage performs a commit after calling `on_next`. This also limited us to only testing sync commits. * Updated test performs the offset check after the pipeline completes when we can be assured that all commits have completed. Fxies nv-morpheus#1217 - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: nv-morpheus#1212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tests/test_kafka_source_stage_pipe.py::test_kafka_source_commiton_next. This also limited us to only testing sync commits.Fxies #1217
By Submitting this PR I confirm: