Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Add Support of PipelineModes in REST Source/Sink Stage #1234

Closed
2 tasks done
spatil44 opened this issue Oct 3, 2023 · 3 comments
Closed
2 tasks done

[FEA]: Add Support of PipelineModes in REST Source/Sink Stage #1234

spatil44 opened this issue Oct 3, 2023 · 3 comments
Assignees
@efajardo-nv
Labels
external This issue was filed by someone outside of the Morpheus team feature request New feature or request

Comments

@spatil44
Copy link

spatil44 commented Oct 3, 2023

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem this feature solves

The current version of the Morpheus REST Source/Sink Stage does not support PipelineModes. As a result, it is not possible to use the REST Source/Sink in building the Pipeline. Building Pipeline through Morpheus CLI is a better and more convenient option as it doesn't require any code change in existing REPO.

Describe your ideal solution

@register_stage("from-http", modes=[PipelineModes.FIL, PipelineModes.NLP, PipelineModes.OTHER])
class HttpServerSourceStage(PreallocatorMixin, SingleOutputSource):

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@spatil44 spatil44 added the feature request New feature or request label Oct 3, 2023
@jarmak-nv jarmak-nv added Needs Triage Need team to review and classify external This issue was filed by someone outside of the Morpheus team labels Oct 3, 2023
@jarmak-nv
Copy link
Contributor

Hi @spatil44!

Thanks for submitting this issue - our team has been notified and we'll get back to you as soon as we can!
In the mean time, feel free to add any relevant information to this issue.

@mdemoret-nv mdemoret-nv removed the Needs Triage Need team to review and classify label Oct 3, 2023
@mdemoret-nv
Copy link
Contributor

Thanks for submitting this issue. This was an oversight and should have been added when the stage was created. I've scheduled this to be fixed in our 23.11 release and assigned a developer.

spatil44 added a commit to spatil44/Morpheus that referenced this issue Oct 4, 2023
@spatil44
Changes related to nv-morpheus#1234
bd09ea6
@spatil44 spatil44 mentioned this issue Oct 4, 2023
Closed
@spatil44
Copy link
Author

spatil44 commented Dec 1, 2023

Closing this issue, More details are on MR

@spatil44 spatil44 closed this as completed Dec 1, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards Dec 1, 2023
mdemoret-nv added a commit that referenced this issue Mar 15, 2024
@mdemoret-nv
Fix a few type-os (#1562)
f52d536 
## Description
<!-- Note: The pull request title will be included in the CHANGELOG. -->
<!-- Provide a standalone description of changes in this PR. -->
<!-- Reference any issues closed by this PR with "closes #1234". All PRs
should have an issue they close-->
Closes 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing
Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these
changes.
- When the PR is ready for review, the documentation is up to date with
these changes.
AnuradhaKaruppiah added a commit that referenced this issue May 16, 2024
@AnuradhaKaruppiah
Update dfp-model-card.md (#1682)
58a572a 
Updating to fields and presentation of fields for Model Card++ 3.0
Release.

## Description
<!-- Note: The pull request title will be included in the CHANGELOG. -->
<!-- Provide a standalone description of changes in this PR. -->
<!-- Reference any issues closed by this PR with "closes #1234". All PRs
should have an issue they close-->
Closes 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing
Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these
changes.
- When the PR is ready for review, the documentation is up to date with
these changes.
AnuradhaKaruppiah added a commit that referenced this issue May 16, 2024
@AnuradhaKaruppiah
Update root-cause-analysis-model-card.md (#1684)
ee9d932 
Updating to fields and presentation of fields for Model Card++ 3.0
Release.

## Description
<!-- Note: The pull request title will be included in the CHANGELOG. -->
<!-- Provide a standalone description of changes in this PR. -->
<!-- Reference any issues closed by this PR with "closes #1234". All PRs
should have an issue they close-->
Closes 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing
Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these
changes.
- When the PR is ready for review, the documentation is up to date with
these changes.
mdemoret-nv added a commit that referenced this issue Jun 12, 2024
@mdemoret-nv
Added tests for NVFoundationLLMService and FaissVectorDbService (#…
9f3b8c1 
…1714)

## Description
<!-- Note: The pull request title will be included in the CHANGELOG. -->
<!-- Provide a standalone description of changes in this PR. -->
<!-- Reference any issues closed by this PR with "closes #1234". All PRs
should have an issue they close-->

- Added tests for NVFoundation (test_nvfoundation_llm_client.py created)
- Added tests for FAISS (test_faiss_vector_db_service.py created)
- Changes to faiss_vdb_service.py (implemented more methods - insert,
delete, count, create)
- Changes to nvfoundation_llm_service.py (api key changes in
NVFoundationLLMService)

Closes 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing
Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these
changes.
- When the PR is ready for review, the documentation is up to date with
these changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efajardo-nv efajardo-nv

Labels
external This issue was filed by someone outside of the Morpheus team feature request New feature or request
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdemoret-nv @efajardo-nv @jarmak-nv @spatil44