Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ModuleCompatibility Type to @nuxt/kit #1096

Open
2nofa11 opened this issue Oct 25, 2024 · 0 comments
Open

Move ModuleCompatibility Type to @nuxt/kit #1096

2nofa11 opened this issue Oct 25, 2024 · 0 comments

Comments

@2nofa11
Copy link

2nofa11 commented Oct 25, 2024

Description

The lib/types.ts file contains a // TODO: Move to @nuxt/kit comment for the ModuleCompatibility type.
Moving this type to @nuxt/kit would improve modularity and make it easier to reuse across modules.

modules/lib/types.ts

Lines 3 to 12 in 5346488

// TODO: Move to @nuxt/kit
// TODO: Support version matrix
export interface ModuleCompatibility {
nuxt: string
devtools?: string
versionMap?: {
[nuxtVersion: string]: string
}
requires: { bridge?: boolean | 'optional' }
}

Proposed Solution

  1. Move ModuleCompatibility type definition to @nuxt/kit.
  2. Update any references in the codebase to import ModuleCompatibility from @nuxt/kit.

Additional Context

Guidance on the preferred location within @nuxt/kit for this type would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant