From f0ae454e28b4f88e1a1546ce2c0b09ae65c0d656 Mon Sep 17 00:00:00 2001 From: "meir.pechthalt" Date: Wed, 5 May 2021 16:46:18 +0300 Subject: [PATCH] helm 2.14 -> 2.17; succeeded pod is always valid --- Dockerfile | 7 ++++--- pkg/utils/validate.go | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Dockerfile b/Dockerfile index 497a278..acbc20d 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.9 -ARG HELM_VERSION=v2.14.0 +ARG HELM_VERSION=v2.17.0 ARG HELM_OS_ARCH=linux-amd64 RUN apk --no-cache add ca-certificates git bash curl jq \ @@ -20,7 +20,8 @@ WORKDIR /home/orca ENV HELM_HOME /home/orca/.helm -RUN helm init -c \ +RUN helm init --stable-repo-url=https://charts.helm.sh/stable --client-only \ + && helm repo add "stable" "https://charts.helm.sh/stable" \ && helm plugin install https://github.com/chartmuseum/helm-push -CMD ["orca"] +CMD ["orca"] \ No newline at end of file diff --git a/pkg/utils/validate.go b/pkg/utils/validate.go index 57c05a7..90148b9 100644 --- a/pkg/utils/validate.go +++ b/pkg/utils/validate.go @@ -55,7 +55,7 @@ func validatePods(name, kubeContext string, envValid bool) (bool, error) { if phase == "Running" { continue } - if phase == "Succeeded" && pod.OwnerReferences[0].Kind == "Job" { + if phase == "Succeeded" { continue } log.Printf("pod %s is in phase \"%s\"", pod.Name, phase)