Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ntnx_vms: New VM: Fragile Code: Specifying Cluster on Non-Multiple Subnet Name Results in Subnet Not Found #387

Open
jhowe-uw opened this issue Aug 2, 2023 · 3 comments
Assignees
Labels
1.9.3_triage Bug fixes & Improvements triage Tickets for triage

Comments

@jhowe-uw
Copy link

jhowe-uw commented Aug 2, 2023

# mention cluster only when there are multiple subnets with same name accross clusters

The code block below states you need to specify the cluster name when the subnet name exists across multiple clusters. However, this puts the onus of detecting multiple subnet names on the user and creates non-DRY ansible playbooks.

Expected:

Stating a cluster name for a subnet should always be successful, regardless if the subnet is a single instance or has multiple instances across clusters.

Actual:

Stating a cluster name on a subnet with no duplicates results in subnet not found

Additional:

Note the misspelling on line 35 of accross ( -> across )

Thanks!

networks:
        - is_connected: True
          subnet:
            name: "{{ subnet_name }}"
            # mention cluster only when there are multiple subnets with same name accross clusters
            # and subnet name is set above
            cluster:
              name: "{{cluster_name}}"
@jhowe-uw jhowe-uw changed the title Fragile Code: Specifying Cluster on Non-Multiple Subnet Name Results in Subnet Not Found Fragile Code: New VM: Specifying Cluster on Non-Multiple Subnet Name Results in Subnet Not Found Aug 2, 2023
@jhowe-uw jhowe-uw changed the title Fragile Code: New VM: Specifying Cluster on Non-Multiple Subnet Name Results in Subnet Not Found [Bug] Fragile Code: New VM: Specifying Cluster on Non-Multiple Subnet Name Results in Subnet Not Found Aug 2, 2023
@jhowe-uw jhowe-uw changed the title [Bug] Fragile Code: New VM: Specifying Cluster on Non-Multiple Subnet Name Results in Subnet Not Found [Bug] ntnx_vms: New VM: Fragile Code: Specifying Cluster on Non-Multiple Subnet Name Results in Subnet Not Found Aug 2, 2023
@bhati-pradeep bhati-pradeep added the triage Tickets for triage label Aug 18, 2023
@Gevorg-Khachatryan-97
Copy link
Contributor

Didn't find the issue.
Could you share some steps and versions of environment that you used to reproduce it.

Thanks in advance @jhowe-uw

@bhati-pradeep bhati-pradeep added the 1.9.1 Bug fixes & Improvements label Sep 25, 2023
@jhowe-uw
Copy link
Author

We have multiple datacenters.

Within our systems, we have multiple computer clusters sharing common VLANs.

These VLAN names can span multiple compute clusters, so we need to specify the cluster name.

As the code comment says:

"mention cluster only when there are multiple subnets with same name accross clusters"

My request is that the code should always accept the cluster name as an arguement for stating the subnet.

Please let me know if you need further clarification.

Thanks

@bhati-pradeep bhati-pradeep added 1.9.3_triage Bug fixes & Improvements and removed 1.9.1 Bug fixes & Improvements labels Aug 5, 2024
@george-ghawali
Copy link
Collaborator

I have tried creating a VM with a unique subnet name and cluster name, it works as expected.
Can you check once if the subnet info has status.cluster_reference.uuid ?
We can surely update the comment that cluster name can be passed in any case of VLAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.9.3_triage Bug fixes & Improvements triage Tickets for triage
Projects
Status: In progress
Development

No branches or pull requests

4 participants