Print rest of line after cursor with large completion menu #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
==========================================
- Coverage 49.32% 49.30% -0.02%
==========================================
Files 46 46
Lines 7988 7991 +3
==========================================
Hits 3940 3940
- Misses 4048 4051 +3
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the buffer is too large to display all at once and you have a completion menu, the text after the cursor isn't displayed. Apparently, it's a difficult problem to show all of the text after the cursor that isn't covered by the menu, but this PR is only for showing the rest of the text on the same line as the cursor.
This is the current behavior. You can't tell which keys I'm pressing in the video, but when I type
foo, then place my cursor beforefooand hit tab to activate the completion menu, thefoodisappears while my cursor is before it. If you move the cursor one word ahead, you'll see thefooagain (my recording doesn't actually show this, I'll make a new one later when I'm not feeling so lazy but you should be able to reproduce on your own computer).This is the new behavior (you can't see the stuff on lines after the current one, but at least you can see the rest of the current line):