You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Perform personedit 1 r/a (or any other invalid rate)
Expected: Error message should state that the rate must be a non-negative rational number
Actual: Error message states that "The rate should not be negative or have more than 2 decimal places". There is no mention that the rate must be a rational number. Furthermore, the error message is incorrect as rates with more than 2 decimal places are allowed (the program just rounds it off to 2 decimal places)
floating point numbers (as used in Java) are by definition rational, since they are limited in precision
we only expect a plain number, which means that users cannot enter reasonably enter an irrational number
the term "rational" may not be familiar to all users, and using this term will only serve to confuse them more
Additionally, while we do not specify that the input has to be a "number", we believe that this will be obvious enough to users, since "negative" and "2 decimal places" implies that the input should be a number of some sort. (A "negative word" or "word with 2 decimal places" doesn't make too much sense in the context of this command, after all.)
Steps to reproduce:
personedit 1 r/a
(or any other invalid rate)Expected: Error message should state that the rate must be a non-negative rational number
Actual: Error message states that "The rate should not be negative or have more than 2 decimal places". There is no mention that the rate must be a rational number. Furthermore, the error message is incorrect as rates with more than 2 decimal places are allowed (the program just rounds it off to 2 decimal places)
[original: nus-cs2103-AY2122S2/pe-interim#3534] [original labels: severity.Low type.FunctionalityBug]
The text was updated successfully, but these errors were encountered: