[WIP][14.0][IMP] account_invoice_batches: report intermediary service #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eantones
approved these changes
Sep 17, 2024
| @@ -14,6 +14,7 @@ | |||
| "l10n_es_facturae", | |||
| "account_invoice_report_service", | |||
| "sale_order_invoicing_grouping_criteria", | |||
| "account_move_service", | |||
There was a problem hiding this comment.
We cannot make this dependent, we have to allow having batches without move service.
Comment on lines
+158
to
+206
| report_service = self.company_id.report_service_id | ||
| if invoices_pdf.filtered(lambda x: x.partner_id.service_intermediary): | ||
| if not self.company_id.report_intermediary_service_id: | ||
| raise UserError( | ||
| _( | ||
| "The report for service intermediary partners is not " | ||
| "defined in the configuration settings. Please go to " | ||
| "the billing configuration and specify which report " | ||
| "will be used." | ||
| ) | ||
| ) | ||
| report_intermediary = self.company_id.report_intermediary_service_id | ||
| pdf_streams = [] | ||
| for invoice in invoices_pdf: | ||
| if invoice.partner_id.service_intermediary: | ||
| if not report_intermediary: | ||
| raise UserError( | ||
| _( | ||
| "The report for service intermediary partners is not " | ||
| "defined in the configuration settings. Please go to " | ||
| "the billing configuration and specify which report " | ||
| "will be used." | ||
| ) | ||
| ) | ||
| report = report_intermediary | ||
| else: | ||
| report = report_service | ||
|
|
||
| pdf_content, _p = report._render_qweb_pdf([invoice.id]) | ||
| pdf_stream = io.BytesIO(pdf_content) | ||
| pdf_streams.append(pdf_stream) | ||
|
|
||
| if pdf_streams: | ||
| merged_pdf_stream = io.BytesIO() | ||
| pdf_merger = PdfFileReader(pdf_content) | ||
| for pdf_stream in pdf_streams: | ||
| pdf_merger.append(pdf_stream) | ||
| pdf_merger.write(merged_pdf_stream) | ||
| pdf_merger.close() | ||
|
|
||
| return { | ||
| "type": "ir.actions.report", | ||
| "report_type": "qweb-pdf", | ||
| "data": {"pdf_content": merged_pdf_stream.getvalue()}, | ||
| "report_name": "Merged_Invoices", | ||
| "name": _("Merged Invoices"), | ||
| } | ||
| else: | ||
| raise UserError(_("No PDFs were generated for the selected invoices.")) |
There was a problem hiding this comment.
Very messy code, copy pasted, please, try to use functions and reuse code. The original code was very clean with a few branches with little code. Please clean the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.