[14.0][ADD] mrp_production_batch: new module #338

KNVx · 2023-11-17T16:32:05Z

No description provided.

eantones · 2023-11-20T13:06:35Z

mrp_production_batch/data/ir_sequence_data.xml

+        <field name="code">mrp.production.batch</field>
+        <field name="prefix">MOB/</field>
+        <field name="padding">5</field>
+        <field name="company_id" eval="False" />


No company??

eantones · 2023-11-20T13:07:21Z

mrp_production_batch/models/mrp_production.py

+    production_batch_id = fields.Many2one(
+        comodel_name="mrp.production.batch",
+        string="Production Batch",
+        readonly=True,


Add ondelete attribute

eantones · 2023-11-20T13:08:07Z

mrp_production_batch/models/mrp_production.py

+    def _check_production_to_batch_consitency(self, mrp_production_ids):
+        if not mrp_production_ids:
+            raise ValidationError(_("No productions selected"))
+        if mrp_production_ids.mapped("production_batch_id"):


Just if mrp_productions.production_batch_id, not needed in 14.0

eantones · 2023-11-20T13:10:42Z

mrp_production_batch/models/mrp_production.py

+            raise ValidationError(
+                _("Some of the selected productions are already done or cancelled")
+            )
+        picking_type_ids = mrp_production_ids.mapped("picking_type_id")


picking_types = mrp_production_ids.picking_type_id

eantones · 2023-11-20T13:12:34Z

mrp_production_batch/models/mrp_production.py

+        readonly=True,
+    )
+
+    def _check_production_to_batch_consitency(self, mrp_production_ids):


Remember the guidelines + typo: consistency

def _check_production_to_batch_consistency(self, mrp_productions):

eantones · 2023-11-20T15:16:03Z

mrp_production_batch/wizard/wizard_mrp_production_batch.py

+    manufacturing_ids = fields.One2many(
+        comodel_name="mrp.production.batch.line.wizard",
+        inverse_name="mrp_production_batch_id",
+        readonly=False,


It is already readonly=False by default

eantones · 2023-11-20T15:17:59Z

mrp_production_batch/wizard/wizard_mrp_production_batch.py

+        for production in self.manufacturing_ids:
+            production.production_batch_id = res.id


It should not be necessary

eantones · 2023-11-20T15:20:01Z

mrp_production_batch/wizard/wizard_mrp_production_batch_line.py

+    _name = "mrp.production.batch.line.wizard"
+    _description = "MRP Production Line Batch wizard"
+
+    mrp_production_batch_id = fields.Many2one(


Rename to production_batch_wizard_id

eantones · 2023-11-20T15:21:04Z

mrp_production_batch/wizard/__init__.py

+from . import wizard_mrp_production_batch
+from . import wizard_mrp_production_batch_line


Check OCA guidelines if this is the way to name wizards and also check the wizard filenames

eantones · 2023-11-20T15:24:29Z

mrp_production_batch/models/stock_picking.py

+
+
+class PickingType(models.Model):
+    _inherit = "stock.picking.type"


This model is not stock.picking it should be in a separate file stock_picking_type. We use OCA guidelines not the Odoo ones...

codecov · 2023-11-21T23:25:52Z

Codecov Report

Attention: Patch coverage is 36.19048% with 201 lines in your changes are missing coverage. Please review.

Project coverage is 44.76%. Comparing base (5dd2c64) to head (06db74e).
Report is 29 commits behind head on 14.0.

Files	Patch %	Lines
mrp_production_batch/models/mrp_production.py	20.75%	84 Missing ⚠️
...rp_production_batch/models/mrp_production_batch.py	31.48%	73 Missing and 1 partial ⚠️
mrp_production_batch/models/stock_picking_type.py	30.95%	29 Missing ⚠️
...uction_batch/wizard/mrp_production_batch_wizard.py	50.00%	8 Missing ⚠️
mrp_production_batch/models/mrp_bom_line.py	66.66%	3 Missing ⚠️
...rp_production_batch/models/stock_production_lot.py	62.50%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             14.0     #338      +/-   ##
==========================================
- Coverage   44.98%   44.76%   -0.23%     
==========================================
  Files         747      759      +12     
  Lines       12972    13313     +341     
  Branches     2836     2924      +88     
==========================================
+ Hits         5835     5959     +124     
- Misses       7005     7221     +216     
- Partials      132      133       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mrp_production_batch/__manifest__.py

mrp_production_batch/models/mrp_production.py

mrp_production_batch/models/mrp_production_batch.py

eantones · 2023-12-12T17:23:33Z

mrp_production_batch/models/mrp_production_batch.py

+                ).button_mark_done()
+            except Exception:
+                productions_display_name.append(production.display_name)
+        if productions_display_name and len(productions_display_name) == len_production:


Why are you doing this len(productions_display_name) == len_production

eantones · 2023-12-12T17:24:46Z

mrp_production_batch/models/mrp_production_batch.py

+    def action_generate_serial(self):
+        for rec in self:
+            for production in rec.production_wo_lot_producing_id:
+                production.action_generate_serial()


We need to change this, the serial numbers should be generated at the time the MO is processed.

mrp_production_batch/models/stock_move.py

mrp_production_batch/readme/CONTRIBUTORS.rst

eantones

LGTM!

eantones

Additionally:

def action_generate_serial(self): this shouldn't be done in a separate step, this should be done seamlessly on process batch.
Do an additional check on process batch. Just in case someone has changed something on a already marked "ready to process" production.

eantones · 2023-12-22T08:59:03Z

mrp_production_batch/models/mrp_production.py

 from odoo.exceptions import ValidationError


 class MrpProduction(models.Model):
    _inherit = "mrp.production"

+    is_ready_to_produce = fields.Boolean(
+        store=True,


This is the default, you don't need to specify this, please remove it

eantones · 2023-12-22T09:00:15Z

mrp_production_batch/models/mrp_production.py

+                        % rec.production_batch_id.name
+                    )
+                elif rec.state == "done":
+                    if not self.env.context.get("mrp_production_batch_create"):


For consistency if mrp_production_batch_create is a boolean
if not self.env.context.get("mrp_production_batch_create", False):

eantones · 2023-12-22T09:14:49Z

mrp_production_batch/models/mrp_production_batch.py

+                message = "The following productions could not be marked as 'done':\n"
+                message += "\n".join(productions_not_ready)
+                raise UserError(message)


message_l = [ "The following productions could not be marked as 'done':", "\n".join(productions_not_ready) ] raise UserError("\n".join(message_l))

eantones · 2023-12-22T10:13:52Z

mrp_production_batch/models/mrp_production_batch.py

-            message = "The following productions could not be marked as 'done':\n"
-            message += "\n".join(productions_display_name)
-            raise UserError(message)
+                with self.env.cr.savepoint():


Use Environment as we discussed

eantones · 2023-12-22T10:14:19Z

mrp_production_batch/models/mrp_production_batch.py

+                    ).button_mark_done()
+                    raise ValidationError(raise_msg)
+            except (ValidationError, UserError) as e:
+                production.is_ready_to_produce = bool(e.name == raise_msg)


This willl be removed using the Environemtn approach

eantones · 2023-12-22T10:15:02Z

mrp_production_batch/models/mrp_production_batch.py

+                    production.error_message = e.name
+                else:
+                    production.error_message = False
+        if not self.env.context.get("mrp_production_check"):


if not self.env.context.get("mrp_production_check", False):

eantones · 2023-12-22T10:34:28Z

mrp_production_batch/models/mrp_production_batch.py

-        productions = self.production_ids.filtered(
-            lambda r: r.state not in ("cancel", "done")
-        )
+        productions = self.production_ids.filtered(lambda r: r.state != "cancel")


Process all productions here and check before if all of them are in "ready" state

eantones

LGTM!
Thanks!

… the recordset exists

mrp_production_batch/i18n/es.po

…al time constraints

…ards

…MO from a Batch and display a notification

KNVx added work in progress to review labels Nov 17, 2023

KNVx requested a review from eantones November 17, 2023 16:32

eantones requested changes Nov 20, 2023

View reviewed changes

eantones removed the to review label Nov 20, 2023

KNVx force-pushed the 14.0-add-mrp_production_batch branch from a3d2b92 to 4f5b5be Compare November 22, 2023 07:58

eantones added the deployed in pre label Nov 30, 2023

FrankC013 added the to review label Dec 12, 2023

FrankC013 requested a review from eantones December 12, 2023 12:12

eantones requested changes Dec 12, 2023

View reviewed changes

eantones added changes requested and removed to review labels Dec 12, 2023

FrankC013 requested a review from eantones December 14, 2023 11:07

FrankC013 added the to review label Dec 14, 2023

FrankC013 force-pushed the 14.0-add-mrp_production_batch branch from bc7b27e to a002267 Compare December 15, 2023 10:29

eantones removed the changes requested label Dec 17, 2023

FrankC013 force-pushed the 14.0-add-mrp_production_batch branch from a182fd1 to f475b92 Compare December 18, 2023 09:14

eantones approved these changes Dec 18, 2023

View reviewed changes

eantones removed the to review label Dec 18, 2023

FrankC013 requested a review from eantones December 21, 2023 17:05

FrankC013 added the to review label Dec 21, 2023

eantones requested changes Dec 22, 2023

View reviewed changes

eantones added changes requested and removed to review labels Dec 22, 2023

FrankC013 added to review and removed changes requested labels Dec 22, 2023

FrankC013 requested a review from eantones December 22, 2023 14:52

eantones approved these changes Dec 22, 2023

View reviewed changes

FrankC013 added 8 commits September 3, 2024 12:58

[FIX] mrp_production_batch: code reviews

ef67dbe

[IMP] mrp_production_batch: new improvements and implementations.

7dce428

[REF] mrp_production_batch: commit reviews

40956ad

[FIX] mrp_production_batch: fix bugs and add some improvements

1488448

[ADD] mrp_production_batch_product_expiry_removal_required

61aa738

[FIX] mrp_production_batch_product_expiry_removal_required: ensure if…

0037523

… the recordset exists

[I18N] mrp_production_batch: improve raise msg

e3e99fa

[REM] mrp_production_batch: removing dead code

2b85d00

FrankC013 force-pushed the 14.0-add-mrp_production_batch branch from 26ee5c2 to 2b85d00 Compare September 3, 2024 10:59

FrankC013 requested a review from eantones September 3, 2024 12:39

FrankC013 added the to review label Sep 3, 2024

eantones approved these changes Sep 3, 2024

View reviewed changes

FrankC013 requested a review from eantones September 4, 2024 10:44

eantones requested changes Sep 4, 2024

View reviewed changes

mrp_production_batch/i18n/es.po Outdated Show resolved Hide resolved

eantones added changes requested and removed to review labels Sep 4, 2024

[IMP] mrp_production_batch: improve error messages

9f3dd72

FrankC013 force-pushed the 14.0-add-mrp_production_batch branch from 7428528 to 9f3dd72 Compare September 4, 2024 10:56

FrankC013 added to review and removed changes requested labels Sep 4, 2024

FrankC013 requested a review from eantones September 4, 2024 10:56

eantones approved these changes Sep 4, 2024

View reviewed changes

[IMP] mrp_production_batch: improve message errors and translation

355e013

FrankC013 requested a review from eantones September 4, 2024 15:48

FrankC013 added 3 commits September 5, 2024 12:17

[FIX] mrp_production_batch: No allow partial batch productions

353a57f

[FIX] mrp_production_batch_product_expiry_removal_required: Fix remov…

4c6c829

…al time constraints

[IMP] mrp_production_batch: Manage production validations through wiz…

e7348e7

…ards

eantones approved these changes Sep 6, 2024

View reviewed changes

eantones removed the to review label Sep 6, 2024

[IMP] mrp_production_batch: don't redirect to the partial order in a …

7a1abc9

…MO from a Batch and display a notification

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][ADD] mrp_production_batch: new module #338

[14.0][ADD] mrp_production_batch: new module #338

KNVx commented Nov 17, 2023

eantones Nov 20, 2023

eantones Nov 20, 2023

eantones Nov 20, 2023

eantones Nov 20, 2023

eantones Nov 20, 2023

eantones Nov 20, 2023

eantones Nov 20, 2023

eantones Nov 20, 2023

eantones Nov 20, 2023

eantones Nov 20, 2023

codecov bot commented Nov 21, 2023 •

edited

Loading

eantones Dec 12, 2023

eantones Dec 12, 2023

eantones left a comment

eantones left a comment

eantones Dec 22, 2023

eantones Dec 22, 2023

eantones Dec 22, 2023

eantones Dec 22, 2023

eantones Dec 22, 2023

eantones Dec 22, 2023

eantones Dec 22, 2023

eantones left a comment

		for production in self.manufacturing_ids:
		production.production_batch_id = res.id

		from . import wizard_mrp_production_batch
		from . import wizard_mrp_production_batch_line



		class PickingType(models.Model):
		_inherit = "stock.picking.type"

[14.0][ADD] mrp_production_batch: new module #338

Are you sure you want to change the base?

[14.0][ADD] mrp_production_batch: new module #338

Conversation

KNVx commented Nov 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Nov 21, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eantones left a comment

Choose a reason for hiding this comment

eantones left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eantones left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 21, 2023 •

edited

Loading