[14.0][FIX] l10n_es_aeat_mod_190: fix memory error when try to install module #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankC013
force-pushed
the
14.0-fix-l10n_es_aeat_mod190-allow_install_module
branch
from
095e586
to
839b7c6
Compare
FrankC013
force-pushed
the
14.0-fix-l10n_es_aeat_mod190-allow_install_module
branch
from
839b7c6
to
492b628
Compare
eantones
requested changes
Nov 15, 2024
There was a problem hiding this comment.
It's broadly correct, but you have to execute the SQL query only during the module installation, on a regular execution the original Python code must be used (you can use "install_mode" of the context). Also you should flush before executing the query to be sure the data are you using (only this data, not all the fields) is already written to the database. Please, check examples of both changes in Odoo code base.
|
I forgot to mention that maybe we should create a nuobit module for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.