feat: more stringent golangci-lint rules #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2024
Merged
jfly
approved these changes
Oct 16, 2024
brianmcgee
force-pushed
the
feat/golangci-lint
branch
2 times, most recently
from
293c2dc to
027390d
Compare
Applies more stringent `golangci-lint` rules to the repository, borrowed from https://github.com/nix-community/go-nix. Also fixes a bug where we were not returning errors when calling `walk.Reader.Read()` in `cmd/format` Signed-off-by: Brian McGee <[email protected]> Co-authored-by: Jeremy Fleischman <[email protected]> Signed-off-by: Brian McGee <[email protected]>
brianmcgee
force-pushed
the
feat/golangci-lint
branch
from
027390d to
fc88f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies more stringent
golangci-lintrules to the repository, borrowed from https://github.com/nix-community/go-nix.Also fixes a bug where we were not returning errors when calling
walk.Reader.Read()incmd/format