Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use meta.mainProgram by default in mkApp #65

Open
yihuang opened this issue May 16, 2022 · 4 comments · May be fixed by #103
Open

Use meta.mainProgram by default in mkApp #65

yihuang opened this issue May 16, 2022 · 4 comments · May be fixed by #103
Labels
enhancement New feature or request

Comments

@yihuang
Copy link

yihuang commented May 16, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

there are many packages specify the mainProgram in meta section, the mkApp should follow that conversion and use bin/$drv.meta.mainProgram by default.

Describe alternatives you've considered

Additional context
@yihuang yihuang added the enhancement New feature or request label May 16, 2022
@zimbatm
Copy link
Member

zimbatm commented May 17, 2022

Indeed. mkApp was added before that heuristic was added to nix. TBH I think mkApp should mostly get deprecated.

@soupglasses
Copy link

Agree on making mkApp itself deprecated. It adds little value and is a confusing abstraction.

I would still recommend adding a warning or note with this that explains that passthru.exePath is no longer used and meta.mainProgram should be used instead. As this would be vastly helpful for anyone who may have set this option in their derivations in the past for mkApp support.

@zimbatm
Copy link
Member

zimbatm commented Aug 19, 2023

Sounds good, do you want to do a PR for it?

soupglasses added a commit to soupglasses/flake-utils that referenced this issue Aug 20, 2023
@soupglasses
deprecate mkApp in favor of direct definitions
9434dbd 
Now that nixpkgs has its own idea of `passthru.exePath` under the
name `meta.mainProgram`, deprecate our solution in favor of the new
standard.

This subsequently removes the value of which `mkApp` brings,
and therefore a full deprecation for its removal has begun.

Closes: numtide#65
@soupglasses soupglasses linked a pull request Aug 20, 2023 that will close this issue
Open
soupglasses added a commit to soupglasses/flake-utils that referenced this issue Aug 20, 2023
@soupglasses
deprecate mkApp in favor of direct definitions
d3952b6 
Now that nixpkgs has its own idea of `passthru.exePath` under the
name `meta.mainProgram`, deprecate our solution in favor of the new
standard.

This subsequently removes the value of which `mkApp` brings,
and therefore a full deprecation for its removal has begun.

Closes: numtide#65
@soupglasses
Copy link

Opened! 😄

soupglasses added a commit to soupglasses/flake-utils that referenced this issue Aug 20, 2023
@soupglasses
deprecate mkApp in favor of direct definitions
29654ae 
Now that nixpkgs has its own idea of `passthru.exePath` under the
name `meta.mainProgram`, deprecate our solution in favor of the new
standard.

This subsequently removes the value of which `mkApp` brings,
and therefore a full deprecation for its removal has begun.

Closes: numtide#65
soupglasses added a commit to soupglasses/flake-utils that referenced this issue Aug 20, 2023
@soupglasses
deprecate mkApp in favor of direct definitions
015166e 
Now that nixpkgs has its own idea of `passthru.exePath` under the
name `meta.mainProgram`, deprecate our solution in favor of the new
standard.

This subsequently removes the value of which `mkApp` brings,
and therefore a full deprecation for its removal has begun.

Closes: numtide#65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deprecate mkApp in favor of direct definitions soupglasses/flake-utils
3 participants
@zimbatm @yihuang @soupglasses