Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added winbox icons #5742

Closed
wants to merge 3 commits into from
Closed

Added winbox icons #5742

wants to merge 3 commits into from

Conversation

cuzrawr
Copy link

@cuzrawr cuzrawr commented Jul 5, 2021

Fixes #5740

Original icon Circle icon Square icon
winbox64 circlenumixwinbox squarenumixwinbox

That app running under wine and need some hardcore fixes, cause most .desktop files are have

...
Icon=/usr/share/pixmaps/winbox64.png
StartupWMClass=winbox64.exe
...

or just:

...
Icon=/usr/share/pixmaps/winbox.png
StartupWMClass=winbox.exe
...

Also, replacing /usr/share/pixmaps/winbox.png works. My dockbar app called "plank" shows new icon properly (here how it looks like):
dockWorks111222

But xfce4-panel looks like this (tried many different combinations with png\svg replacement but seems wine didn't eat ico properly and shows hardcoded into .exe):
buggedOne233344

btw that are not big problem at all, because in my dock now everything is in harmony with square icons. :-)

changed title
changed title
Copy link
Author

@cuzrawr cuzrawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tittle mistype

@cuzrawr cuzrawr changed the title Added winbox icons \ need review #5740 Added winbox icons \ need review ( issue #5740 ) Jul 5, 2021
@ramonGonzEdu
Copy link

How come the circle icon seems to have a smaller "greener" circle inside? shouldn't it be all 1 color?

@palob palob added the merge label Jul 14, 2021
Copy link
Member

@palob palob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution.
Your icons contain encapsulated raster graphics. This defies the purpose of vector (SVG) icons, the icons won't scale up this way.
What is more, when I open the files in Inkscape I just see white circle on top of the baseplate.

@Foggalong Foggalong changed the title Added winbox icons \ need review ( issue #5740 ) Added winbox icons Aug 30, 2021
@ingria
Copy link
Contributor

ingria commented Feb 20, 2022

Something like this maybe?

64 32 16

The shadow looks to thick IMO

source svg

winbox_compressed

@palob
Copy link
Member

palob commented Feb 20, 2022

From distance the symbol looks a bit big. It should fit inside a 30px X 30px circle (like the one in the template files).

The crescent shapes should be composed by means of a path difference of 2 circles and need to be aligned to the pixel grid.
Can you open a new PR?

@ingria ingria mentioned this pull request Feb 21, 2022
@palob
Copy link
Member

palob commented Feb 18, 2023

Closing in favour of #5777.

@palob palob closed this Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Icon Request: winbox
4 participants