Address PR comments

nulib · Jul 1, 2024 · 3392747 · 3392747
1 parent 348af5a
commit 3392747
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 13 deletions.
diff --git a/node/src/handlers/post-chat-feedback.js b/node/src/handlers/post-chat-feedback.js
@@ -18,24 +18,27 @@ const feedbackSchema = {
           type: "array",
           items: { type: "string" },
         },
-        required: ["ref", "question", "answer", "source_documents"],
       },
-      feedback: {
-        type: "object",
-        properties: {
-          options: { type: "array", items: { type: "string" } },
-          text: { type: "string" },
-          email: { type: "string" },
-        },
-        required: ["options", "text"],
+      required: ["ref", "question", "answer", "source_documents"],
+      additionalProperties: false,
+    },
+    feedback: {
+      type: "object",
+      properties: {
+        options: { type: "array", items: { type: "string" } },
+        text: { type: "string" },
+        email: { type: "string" },
       },
+      required: ["options", "text", "email"],
+      additionalProperties: false,
     },
-    required: ["sentiment", "context", "feedback"],
   },
+  required: ["sentiment", "context", "feedback"],
+  additionalProperties: false,
 };
 
 const handler = wrap(async (event, context) => {
-  if (!event.userToken.isLoggedIn()) {
+  if (!event.userToken.isLoggedIn() && !event.userToken.isSuperUser()) {
     return {
       statusCode: 401,
       headers: { "Content-Type": "text/plain" },

diff --git a/template.yaml b/template.yaml
@@ -694,7 +694,7 @@ Resources:
           Type: HttpApi
           Properties:
             ApiId: !Ref dcApi
-            Path: /chat-endpoint
+            Path: /chat/endpoint
             Method: GET
   chatFeedback:
     Type: AWS::Serverless::Function
@@ -725,7 +725,7 @@ Resources:
           Type: HttpApi
           Properties:
             ApiId: !Ref dcApi
-            Path: /chat-feedback
+            Path: /chat/feedback
             Method: POST
   chatFeedbackBucket:
     Type: 'AWS::S3::Bucket'